Conversation
- Drop macos-13 (Intel) runners — they queue for 2h+ and never complete, stalling the whole CI run; use macos-14 (Apple silicon) + macos-latest. - 32-bit Linux build: configure --with-mutex=POSIX/pthreads to avoid the x86 test-and-set path (mutex_int.h 'unknown type name tsl_t' under -m32). - OCR review job: continue-on-error so it's advisory and never blocks a PR (e.g. while AWS OIDC role trust is being configured). Note: OCR's AssumeRoleWithWebIdentity failure is an AWS IAM trust-policy issue (role must trust token.actions.githubusercontent.com for repo:berkeleydb/libdb), not a workflow bug.
- meson.build: add -D_DEFAULT_SOURCE/-D_BSD_SOURCE so glibc exposes the BSD
type names (u_int, u_char, u_long, u_int8_t ...) that db.h uses; macOS/*BSD
provide them unconditionally (no-op). Fixes the meson/ninja and nix-flake
jobs on Linux ('unknown type name u_int').
- ci.yml: exclude the --enable-cxx config on macOS; BDB's C++ headers don't
compile against Xcode's libc++ <atomic> (macOS-specific; Linux cxx is fine).
gburd
added a commit
that referenced
this pull request
Jul 31, 2026
ci: unstick CI (drop macos-13), fix 32-bit mutex build, make OCR advisory
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the stuck/failed CI observed after the recent merges.
macos-13runners queued for 2h+ and never completed, stalling the entire matrix. Switched tomacos-14(Apple silicon) +macos-latest.continue-on-error, but now fixed):-m32selected the x86 test-and-set mutex path →mutex_int.h: unknown type name 'tsl_t'. Configure with--with-mutex=POSIX/pthreads.continue-on-errorso it's advisory and never blocks a PR.Action required (AWS side, not code)
OCR fails at
sts:AssumeRoleWithWebIdentity(Not authorized). The repo variables are set, but the IAM role inAWS_ROLE_ARNneeds a trust policy allowing GitHub OIDC for this repo, e.g. principaltoken.actions.githubusercontent.comwithsublikerepo:berkeleydb/libdb:*and audiencests.amazonaws.com. Once that's set, OCR will authenticate.