Skip to content

docs: link upstream issue ggml-org/llama.cpp#26416 for patch 0001 - #375

Merged
bernardladenthin merged 1 commit into
mainfrom
docs/upstream-issue-26416
Aug 1, 2026
Merged

docs: link upstream issue ggml-org/llama.cpp#26416 for patch 0001#375
bernardladenthin merged 1 commit into
mainfrom
docs/upstream-issue-26416

Conversation

@bernardladenthin

Copy link
Copy Markdown
Owner

Summary

  • The argv-substitution finding behind patch 0001 is now reported upstream as ggml-org/llama.cpp#26416 (label bug-unconfirmed, first bad commit 508a475, the #24779 merge).
  • Records that state where it is needed: at the top of docs/upstream-investigation-win32-argv-substitution.md, in the patch table in CLAUDE.md, and in the TODO.md entry.
  • Notes the consequence explicitly: the issue asks the maintainers which of the two directions they want, so 0001 stays downstream until they answer rather than turning into an unannounced 37-file pull request.

Documentation only. No patch file, build file or source is touched.

Test plan

  • Affected unit / integration tests pass locally
  • CI is green on this branch
  • Docs / CHANGELOG updated where applicable

No tests were run: the change touches only Markdown. No patch under llama/patches/ and no build input is modified, so neither the native build nor the applier is affected.

Related issues / PRs

Checklist

  • I have read CONTRIBUTING.md and CODE_OF_CONDUCT.md
  • My commits follow Conventional Commits
  • No security-sensitive changes (if there are, I have notified the maintainer privately per SECURITY.md)

The argv-substitution finding is now reported upstream. Record the issue in
the investigation document, the patch table and TODO, so the downstream patch
carries its upstream state.

Assisted-by: Claude Opus 5
@bernardladenthin
bernardladenthin merged commit 7ec14df into main Aug 1, 2026
8 of 14 checks passed
@bernardladenthin
bernardladenthin deleted the docs/upstream-issue-26416 branch August 1, 2026 21:24
@claude

claude Bot commented Aug 1, 2026

Copy link
Copy Markdown

Approved — This documentation update correctly links and tracks the upstream issue ggml-org/llama.cpp#26416 for patch 0001.

Strengths:

  • Accurate and consistent documentation across all three files (CLAUDE.md, TODO.md, investigation doc)
  • Clear explanation of the patch status (waiting on upstream direction)
  • Proper traceability for future maintainers
  • Well-formatted commit message following Conventional Commits
  • No code or build changes, appropriate test plan

No issues found — The changes are minimal, focused, and provide valuable context for understanding the current upstream coordination status.

@sonarqubecloud

sonarqubecloud Bot commented Aug 1, 2026

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant