Skip to content

Add ability to override project id - #63

Merged
jeromegamez merged 2 commits into
beste:mainfrom
rogierknoester:main
Jul 7, 2024
Merged

Add ability to override project id#63
jeromegamez merged 2 commits into
beste:mainfrom
rogierknoester:main

Conversation

@rogierknoester

Copy link
Copy Markdown
Contributor

Description

Sometimes credentials are from a different GCP project than the service being used (e.g. a workload in project A needs to access apps in project B). These changes allow overriding the project id, as it is usually part of the service account's credentials already.

Fixes #62

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have added tests that prove my fix is effective or that my feature works
  • I have made corresponding changes to the documentation

@jeromegamez jeromegamez left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much, this is a perfect PR! 🫶🏻

@jeromegamez
jeromegamez merged commit bc4e168 into beste:main Jul 7, 2024
@jeromegamez

Copy link
Copy Markdown
Member

I will release it tomorrow when I'm back at my desk!

@jeromegamez

Copy link
Copy Markdown
Member

@rogierknoester

Copy link
Copy Markdown
Contributor Author

Thanks for the quick responses!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Overriding project id per configuration entry

2 participants