Skip to content

add support for php 8.5 and symfony 8.0 - #74

Merged
jeromegamez merged 3 commits into
beste:mainfrom
Bleksak:main
Nov 29, 2025
Merged

add support for php 8.5 and symfony 8.0#74
jeromegamez merged 3 commits into
beste:mainfrom
Bleksak:main

Conversation

@Bleksak

@Bleksak Bleksak commented Nov 29, 2025

Copy link
Copy Markdown
Contributor

Description

Add support for symfony 8.0 and php 8.5, with added test coverage

Fixes #72

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have added tests that prove my fix is effective or that my feature works
  • I have made corresponding changes to the documentation

@Bleksak
Bleksak requested a review from jeromegamez as a code owner November 29, 2025 10:52
@Bleksak

Bleksak commented Nov 29, 2025

Copy link
Copy Markdown
Contributor Author

probably need to replace Xml config with Php one as the xml loader was removed in symfony 8

@Bleksak

Bleksak commented Nov 29, 2025

Copy link
Copy Markdown
Contributor Author

had to fix some tests, probably ready for review

@jeromegamez

Copy link
Copy Markdown
Member

If it makes things easier, you can drop support for Symfony <6.4 and <7.4 so that the composer.json only has ^6.4||^7.4||^8.0, according to the supported Symfony versions at https://symfony.com/releases. I'd skip 7.3 because it's EOL soon enough.

@Bleksak
Bleksak force-pushed the main branch 2 times, most recently from db7d882 to 6e7c5a8 Compare November 29, 2025 18:40
@Bleksak

Bleksak commented Nov 29, 2025

Copy link
Copy Markdown
Contributor Author

okay i had to drop phpunit back to ^10 because 11 and 12 are not supported by php 8.1/8.2, but the tests go through now

@jeromegamez jeromegamez mentioned this pull request Nov 29, 2025
4 tasks
@jeromegamez

Copy link
Copy Markdown
Member

The tests don't run for all PHP and Symfony versions:

CleanShot 2025-11-29 at 22 59 53@2x

But I'll deal with this later. Thank you for your contribution, much appreciated!

@jeromegamez
jeromegamez merged commit 2b4867a into beste:main Nov 29, 2025
@jeromegamez

Copy link
Copy Markdown
Member

Released with 5.7.0, thanks again!

@Bleksak

Bleksak commented Nov 29, 2025

Copy link
Copy Markdown
Contributor Author

Thanks for the quick merge and release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Symfony 8 support

2 participants