LDAPImport start_tls

[wheldom01]

Patch adds support for the use of Net::LDAP start_tls to the LDAPImport.

[sunnavy]

Sorry for the late response.

I have 2 main concerns:

• it looks like Net::LDAP::start_tls accepts hash instead of hashref

but in your code:

$msg = $ldap->start_tls( $RT::LDAPTLS );

I'm wondering if it works.

• $msg returned by start_tls isn't checked

We probably need to check it to see if there are any errors, just like the way we check $ldap->bind.

Thanks!

[wheldom01]

Hi, No problem, I'll take a look as this this evening as it is a while since I wrote this patch. Best Regards Martin

…

On 2018-02-07 15:46, sunnavy wrote: Sorry for the late response. I have 2 main concerns: * it looks like Net::LDAP::start_tls accepts hash instead of hashref but in your code: $msg = $ldap->start_tls( $RT::LDAPTLS ); I'm wondering if it works. * $msg returned by start_tls isn't checked We probably need to check it to see if there are any errors, just like the way we check $ldap->bind. Thanks! -- You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub [1], or mute the thread [2]. * Links: ------ [1] #213 (comment) [2] https://github.com/notifications/unsubscribe-auth/AOnrJPqRL2DRQwpdbceyHaVK5KrEoPyBks5tScVVgaJpZM4MohyZ

[tobiasbp]

It would be great if this could be completed and merged in. Thanks.

[tobiasbp]

Is this change compatible with RT 4.4.4? This is the message I receive when running it:
Unable to run rt-ldapimport without dependencies. Rerun configure with the --enable-externalauth option

[wheldom01]

Hi, I believe that it should still be compatible, but can't confirm that as I'm not running 4.4.4 yet. Could you confirm that the LDAPTLS variable is set correctly? Set($LDAPTLS, { 'verify' => 'require', 'cafile' => '/etc/ssl/certs/CACert.pem', } ); # Path CA file I'll try to test it over the weekend. Best Regards Martin

…

On 2019-09-13 10:48, Tobias Balle-Petersen wrote: Is this change compatible with RT 4.4.4? This is the message I receive when running it: Unable to run rt-ldapimport without dependencies. Rerun configure with the --enable-externalauth option -- You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub [1], or mute the thread [2]. Links: ------ [1] #213?email_source=notifications&email_token=ADU6WJDUIOFOB3CE2QN5TZTQJNOV7A5CNFSM4DFCDSM2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6URLGI#issuecomment-531174809 [2] https://github.com/notifications/unsubscribe-auth/ADU6WJBMTZSTBLM5USABQCTQJNOV7ANCNFSM4DFCDSMQ

[wheldom01]

Hi, You will need the following modules installed to. Crypt::SSLeay IO::Socket::SSL Net::SSLeay Best Regards Martin

…

On 2019-09-13 10:48, Tobias Balle-Petersen wrote: Is this change compatible with RT 4.4.4? This is the message I receive when running it: Unable to run rt-ldapimport without dependencies. Rerun configure with the --enable-externalauth option -- You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub [1], or mute the thread [2]. Links: ------ [1] #213?email_source=notifications&email_token=ADU6WJDUIOFOB3CE2QN5TZTQJNOV7A5CNFSM4DFCDSM2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6URLGI#issuecomment-531174809 [2] https://github.com/notifications/unsubscribe-auth/ADU6WJBMTZSTBLM5USABQCTQJNOV7ANCNFSM4DFCDSMQ

[cbrandtbuffalo]

In 4c288fc, we ended up modifying LDAPImport to allow passing any arguments supported by Net::LDAP, so this is now covered. We also added TLS options to the example so it's clear how to configure a secure connection. This is available in RT 4.4.4 and newer, including RT 5.

Thanks for opening a PR and suggesting the improvement!