switch languages without an app restart #1555

Docteh · 2019-08-03T07:55:11Z

Hello, Looks like anything except the GUI.log can be re-translated on the fly.

Give it a go. I'll fix the commit with a revision to locales/en/messages.json if needed. But maybe we can just drop the string that says that a restart is required.

<span i18n="userLanguageSelect" class="i18n-replaced">Sprache (Das Programm muss zur Änderung neu gestartet werden)</span>

mikeller

Wow, I didn't expect this to be possible so easily.

mikeller · 2019-08-03T13:35:15Z

Except that the builds are failing. :-(

Docteh · 2019-08-03T19:13:39Z

Whoops, not the only bug.

Also fixed.

McGiverGim · 2019-08-03T20:32:56Z

I did a similar feature when I made the translation system, and @mikeller asked to remove this live language change because not all is changed. Some combos that are loaded in the js and other thinks are not translated. I suggested some workarounds but it was some more little work for the developers.

I will look at the discussion to see if I can find it...

McGiverGim · 2019-08-03T20:43:21Z

Here is the original PR #892

Docteh · 2019-08-03T22:32:52Z

Thanks I'll take a closer look at what doesn't update. If we can get the last percentage fixed I think we can make a strong case going forward for people to keep things translatable on the fly. I figure that the log could be left alone just because of how logs work. Sometimes these things need to sneak up in stages.

I should benchmark the retranslation compared to asking it to translate new items in the document.

mikeller · 2019-08-03T22:52:10Z

@McGiverGim: Good point, I remember now. My point still stands that, if this requires extra coding effort and understanding from people wanting to contribute to the configurator, then this disadvantage outweighs the benefits we get from it. After all, for the majority of users, selecting the language will be a one-off operation, and they won't have any need to switch the language again after selecting the one they want, so having to restart the application for this is only a very minor inconvenience.

@Docteh: Agreed that leaving the log in whatever language it was generated is acceptable.

Docteh · 2019-08-04T08:16:09Z

Here is an example of an item that is tricky to retranslate. The two drop downs above it are easier.

Does it really need to say "Choose version for ....."? I figure just selecting the latest version should be fine. Or just make it unspecific.

mikeller · 2019-08-04T12:06:47Z

@Docteh:

Does it really need to say "Choose version for ....."? I figure just selecting the latest version should be fine. Or just make it unspecific.

That again for me turns into a matter of deciding what is more important - the capability to change languages without a restart, or the capability to add translations to whatever we want without restriction, and without having to think about what is working and what isn't.

Docteh · 2019-08-04T23:36:23Z

How about a compromise?

We could only change the language if the GUI doesn't think its connected.

Leave the message stating that a restart is required.

Right now if something on a tab doesn't switch languages, you can just go to a different tab, and then come back.

mikeller · 2019-08-04T23:41:13Z

Interesting point, I never looked at it this way, but since tabs are reloaded entirely on every change this will work.

Or take this in a different direction, and put the language drop down into the landing tab (this makes it easier to discover for somebody not fluent in the display language as well).

Docteh · 2019-08-05T00:15:12Z

Put the language switcher on the landing page? I like that idea. That'll be my next move.

Docteh · 2019-08-05T21:13:28Z

Looking for input, this probably needs a touch of design work. I thought about throwing the selector widget into the page, and ended up researching language choosers for a bit. I like having the list.

mikeller · 2019-08-05T22:01:58Z

I like it - it shows the option in your language / alphabet right on startup - doesn't go much more straightforward than that.
Speaking from experience of clicking through a plethora of drop downs filled with Chinese characters in search of the one listing 'English', I think this is great.
I'd just add a blurb up top explaining that this is to select the language, and will be stored permanently. And maybe change 'Default' to 'System Default', or add a blurb explaining that this is whatever language your system is in (if available).

McGiverGim

I'm not too sure about the change. In this way we have options in the main page, and different options to select in the menu. I like to have all of them in the same manner.

If we finally do this change, maybe is better to make it more visual, maybe add a little flag before each text. If not, I'm pretty sure that most people will not read it.

locales/en/messages.json

src/js/localization.js

src/js/tabs/landing.js

Docteh · 2019-08-06T08:31:18Z

For the languages, not sure if I want like English (en) or just English. Leaning towards just English. I'll remove eg languagebr_en from the english locale file if we go that way otherwise its useful.

McGiverGim · 2019-08-06T10:03:44Z

The locales were there to give "some order" to the texts. They are ordered by locale. I don't know if now, without them, it seems more only a mesh of languages...

mikeller · 2019-08-06T10:47:59Z

I am a bit on the fence about adding the locale for every language to the list - my sense of ordering likes it, my sense of curiosity likes to be able to see what the languages not using the latin alphabet are, but my sense of aestethics just loves the simplicity of the list of languages without any distractions.

But one thing I think we need to address is that currently the cursor when hovering over the language names is text selection - this makes it harder than needed to discover that they are clickable.

Docteh · 2019-08-06T20:57:17Z

I switched the spans out for links, so they'll be more obviously clickable.

We could also do something to the text on hover. Like underline, or a color change.

mikeller

Looking good now. Can you rebase / squash please?

mikeller · 2019-08-06T10:52:14Z

locales/fake/messages.json

@@ -0,0 +1,6 @@
+{
+    "language_default_pretty": {


Or to be more precise: What is this used for?

In English language_default_pretty is fully defined: "System Default ($t(detectedLanguage))"

This works as a fallback as many languages have language_default translated.

messing with fallback might be a way to rename a key, and not lose the translated content.

tabLanding
defaultChangelogAction
defaultPrivacyPolicyAction
tabHelp
tabFirmwareFlasher

Not sure I understand this right, but the way fallbackLng is used it looks now like fake is the only language that will ever be used as fallback language. This is probably not what we want.

Also, should this mythical language maybe be called fallback or similar instead of fake?

I believe the fallback is to english. We can specify multiple fallback languages. So for defaultDonateBottom on the landing page gets english when using german. (my change to the link ended up wiping out the translations).

Have a look at the code. Only the first element of fallbackLng seems to ever be used. Is it possible that English is a hardcoded default fallback for the framework we are using?

In i18next or in our code? We are injecting information (resources) into the first fallbackLng, but I figured that would be okay to ignore. I figure it'd be an annoying problem to throw out a language while running, even if its a fake one.

For this screenshot I made did fallbackLng: ['fallback','de','en'], and then loaded polish translation manually i18next.changeLanguage('pl')

Sorry, my bad, I'd assumed fallbackLng was an option that we'd added (dodgy name and all).

Docteh · 2019-08-08T01:22:48Z

Looks like I did something slightly wrong. I'll try to fix.

Let me know on the fallback fakery.

mikeller · 2019-08-09T01:03:00Z

src/js/tabs/landing.js

 TABS.landing = {};
 TABS.landing.initialize = function (callback) {
-    var self = this;
+  var self = this;


This file will need to have the indentation adjusted at some point (not in this pull request though).

mikeller · 2019-08-09T01:03:45Z

@McGiverGim: Is this ok now?

McGiverGim · 2019-08-09T07:23:49Z

My review yes, now has been fixed. But I don't understand all this fallback language. @Docteh can you explain why it is needed? I see that you have translations that recommend to translate in other place, translations that are in the fallback...

locales/en/messages.json

McGiverGim · 2019-08-09T07:28:10Z

It seems it has been done in this way to maintain some actual translations. If they are not valid/needed the correct way is to remove/change them. I don't have too much time now to look deeply to the PR, so if it is needed for certain reasons sorry, I have not see them.

Docteh · 2019-08-10T04:36:41Z

Oh, probably should have commented that the fallback modifications are pulled.

McGiverGim

I think we will need to add something like a flag to make them more visible but is ok for now. Good job!

mikeller previously approved these changes Aug 3, 2019

View reviewed changes

mikeller added this to the 10.6.0 milestone Aug 3, 2019

mikeller added the RN: IMPROVEMENT label Aug 3, 2019

Docteh dismissed mikeller’s stale review via 643d726 August 3, 2019 19:12

Docteh force-pushed the tooslow branch from 2467809 to 643d726 Compare August 3, 2019 19:12

Docteh changed the title ~~switch languages on the fly, or find out why not~~ switch languages without an app restart Aug 5, 2019

McGiverGim requested changes Aug 6, 2019

View reviewed changes

locales/en/messages.json Show resolved Hide resolved

src/js/localization.js Show resolved Hide resolved

src/js/tabs/landing.js Outdated Show resolved Hide resolved

Docteh force-pushed the tooslow branch from 084fa36 to ac080be Compare August 6, 2019 08:32

Docteh mentioned this pull request Aug 6, 2019

add an alternative to chrome.storage.local #1550

Merged

mikeller added the rebase / squash required label Aug 7, 2019

mikeller previously approved these changes Aug 7, 2019

View reviewed changes

Docteh dismissed mikeller’s stale review via 8d7da5d August 8, 2019 01:20

Docteh force-pushed the tooslow branch from 2c29f40 to 8d7da5d Compare August 8, 2019 01:20

Docteh force-pushed the tooslow branch from 8d7da5d to 5d9986f Compare August 8, 2019 01:24

mikeller removed the rebase / squash required label Aug 8, 2019

Docteh force-pushed the tooslow branch from 5d9986f to 773936a Compare August 8, 2019 22:04

mikeller previously approved these changes Aug 9, 2019

View reviewed changes

McGiverGim approved these changes Aug 9, 2019

View reviewed changes

McGiverGim requested changes Aug 9, 2019

View reviewed changes

locales/en/messages.json Outdated Show resolved Hide resolved

switch languages without an app restart

ea1aaf7

Docteh dismissed mikeller’s stale review via ea1aaf7 August 10, 2019 00:04

Docteh force-pushed the tooslow branch from 773936a to ea1aaf7 Compare August 10, 2019 00:04

mikeller approved these changes Aug 10, 2019

View reviewed changes

McGiverGim approved these changes Aug 10, 2019

View reviewed changes

mikeller merged commit 7e371ee into betaflight:master Aug 10, 2019

Docteh deleted the tooslow branch August 11, 2019 20:44

j4k0xb mentioned this pull request Sep 19, 2024

Add language option #4174

Merged

Uh oh!

switch languages without an app restart #1555

switch languages without an app restart #1555

Conversation

Docteh commented Aug 3, 2019

Uh oh!

mikeller left a comment

Choose a reason for hiding this comment

Uh oh!

mikeller commented Aug 3, 2019

Uh oh!

Docteh commented Aug 3, 2019

Uh oh!

McGiverGim commented Aug 3, 2019

Uh oh!

McGiverGim commented Aug 3, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Docteh commented Aug 3, 2019

Uh oh!

mikeller commented Aug 3, 2019

Uh oh!

Docteh commented Aug 4, 2019

Uh oh!

mikeller commented Aug 4, 2019

Uh oh!

Docteh commented Aug 4, 2019

Uh oh!

mikeller commented Aug 4, 2019

Uh oh!

Docteh commented Aug 5, 2019

Uh oh!

Docteh commented Aug 5, 2019

Uh oh!

mikeller commented Aug 5, 2019

Uh oh!

McGiverGim left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Docteh commented Aug 6, 2019

Uh oh!

McGiverGim commented Aug 6, 2019

Uh oh!

mikeller commented Aug 6, 2019

Uh oh!

Docteh commented Aug 6, 2019

Uh oh!

mikeller left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Docteh Aug 9, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Docteh commented Aug 8, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mikeller commented Aug 9, 2019

Uh oh!

McGiverGim commented Aug 9, 2019

Uh oh!

Uh oh!

McGiverGim commented Aug 3, 2019 •

edited

Loading

Docteh Aug 9, 2019 •

edited

Loading