Language user selectable in app #892
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a select in the options menu to let the user select the prefered language for the app.
The language is hot changed, but with some problems in the actual code:
.jsfile (like selects, for example), remains with the older language..js(like theconnectanddisconnecttext button) return to the original value.All the problems are easily solvable. When adding an element to a select, or changing the content of a button, we need to add or change the
i18nattribute too.We can do two things:
I prefer the second solution, as I say is not as difficult, and the problems with the selects is a minor problem that with a tab change is solved.