Skip to content

bump nwjs to latest version #2130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 20, 2020
Merged

bump nwjs to latest version #2130

merged 1 commit into from
Jul 20, 2020

Conversation

@TheIsotopes
Copy link
Contributor

@TheIsotopes TheIsotopes commented Jul 18, 2020 •
edited
Loading

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.

Bug C 2 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.2% 0.2% Duplication

@TheIsotopes TheIsotopes mentioned this pull request Jul 18, 2020
Closed
@mikeller
Copy link
Member

@TheIsotopes:

command line switch --disable-gpu is not needed anymore

This is incorrect - --disable-gpu is not needed by everybody who is using non-outdated GPU drivers - please fix your comment.

@TheIsotopes
Copy link
Contributor Author

@mikeller comment removed
why sonarcloud failed? i'm only edited the version number!?

@McGiverGim
Copy link
Member

Because your code is not up to date with master. A rebase will fix it.

@mikeller mikeller added this to the 10.8.0 milestone Jul 19, 2020
@TheIsotopes
Copy link
Contributor Author

TheIsotopes commented Jul 19, 2020 •
edited
Loading

@McGiverGim nothing has been changed to master since yesterday, so it should be up to date

I can't rebase online. pls, an admin can do this

@mikeller mikeller merged commit 1f1c97e into betaflight:master Jul 20, 2020
@TheIsotopes TheIsotopes deleted the patch-2 branch July 20, 2020 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mikeller mikeller mikeller approved these changes

Assignees

No one assigned

Labels

RN: IMPROVEMENT

Projects

None yet

Milestone

10.8.0

Development

Successfully merging this pull request may close these issues.

3 participants

@TheIsotopes @mikeller @McGiverGim