Skip to content

Workflow improvement - add option for non-PR manual builds #3046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 14, 2022
Merged

Workflow improvement - add option for non-PR manual builds #3046

merged 1 commit into from
Oct 14, 2022

Conversation

@nerdCopter
Copy link
Member

@nerdCopter nerdCopter commented Oct 13, 2022 •
edited
Loading

  • allow manually triggered builds via manual-build.yml (artifacts only, no release).
  • allows fork-owners to easily build all OS versions via actions tab.
  • useful for fork-owner testing, prior to making PR's.
  • names the workflow-run appropriately with branch-name and debug if applicable.
  • reference discussions in ci.yml - workflow_dispatch #3043

image

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 13, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@haslinghuis haslinghuis modified the milestone: 10.9.0 Oct 13, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Oct 13, 2022

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-macOS
Betaflight-Configurator-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@blckmn
Copy link
Member

blckmn commented Oct 13, 2022 •
edited
Loading

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> PASS
  • assigned to a milestone -> FAIL
  • cooling off period lapsed -> FAIL
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> FAIL
  • approver count at least three -> PASS

@blckmn blckmn self-requested a review October 13, 2022 22:20
@haslinghuis haslinghuis merged commit b5c2216 into betaflight:master Oct 14, 2022
@nerdCopter nerdCopter mentioned this pull request Aug 22, 2023
Merged
@nerdCopter nerdCopter deleted the 20221013_github_actions_workflow_manual_build branch October 31, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@McGiverGim McGiverGim McGiverGim approved these changes

@blckmn blckmn blckmn approved these changes

@haslinghuis haslinghuis haslinghuis approved these changes

@asizon asizon Awaiting requested review from asizon

Assignees

@nerdCopter nerdCopter

Labels

Ready to Merge RN: BUILD SYSTEM

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nerdCopter @blckmn @McGiverGim @haslinghuis