Fix for unable to update gyro lowpass. #164
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to update the gyro lowpass filter the value is set to it's original value when saving.
This is because https://github.com/betaflight/betaflight/blob/793c5f7b71db746146a086e5c667759a0f13d415/src/main/interface/msp.c#L1248 contains TWO sbufWriteU8(dst, gyroConfig()->gyro_lowpass_hz);.
When sending the data from the lua script, the modified value is set here: https://github.com/betaflight/betaflight/blob/793c5f7b71db746146a086e5c667759a0f13d415/src/main/interface/msp.c#L1814
And the original value is set here: https://github.com/betaflight/betaflight/blob/793c5f7b71db746146a086e5c667759a0f13d415/src/main/interface/msp.c#L1833 overwriting the modified value.
Sending only 18 bytes back prevents betaflight from entering that last if-statement.
This is my first pull request. Hope i did it right.