Skip to content

Fix read of DPS310 coef C11 #11898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
KarateBrot merged 1 commit into from
Oct 17, 2022
Merged

Fix read of DPS310 coef C11 #11898

KarateBrot merged 1 commit into from
Oct 17, 2022

Conversation

@SteveCEvans
Copy link
Member

@SteveCEvans SteveCEvans commented Oct 16, 2022 •
edited
Loading

Fixes: #11809

The reading of the compensation coefficients described in section 8.11, Calibration Coefficients (COEF), of the datasheet at https://www.infineon.com/dgdl/Infineon-DPS310-DataSheet-v01_02-EN.pdf?fileId=5546d462576f34750157750826c42242 was erroneously reading the C11 value from the C01 register.

@SteveCEvans SteveCEvans added this to the 4.4 milestone Oct 16, 2022
@SteveCEvans SteveCEvans self-assigned this Oct 16, 2022
@github-actions

This comment has been minimized.

Sign in to view
KarateBrot
KarateBrot previously approved these changes Oct 16, 2022
View reviewed changes
Copy link
Member

@KarateBrot KarateBrot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 🤯

haslinghuis
haslinghuis previously approved these changes Oct 16, 2022
View reviewed changes
@blckmn
Copy link
Member

blckmn commented Oct 16, 2022 •
edited
Loading

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> FAIL
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> PASS
  • approver count at least three -> PASS

@SteveCEvans SteveCEvans dismissed stale reviews from haslinghuis and KarateBrot via d4237bb October 16, 2022 20:46
@github-actions
Copy link

github-actions bot commented Oct 16, 2022

Do you want to test this code? Here you have an automated build:
Assets
WARNING: It may be unstable. Use only for testing! See: https://www.youtube.com/watch?v=I1uN9CN30gw for instructions for unified targets!

@ctzsnooze
Copy link
Member

ctzsnooze commented Oct 16, 2022

Thanks @SteveCEvans - we really appreciate what you do!

@KarateBrot KarateBrot merged commit 90bac0e into betaflight:master Oct 17, 2022
@SteveCEvans SteveCEvans mentioned this pull request Nov 21, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@blckmn blckmn blckmn approved these changes

@haslinghuis haslinghuis haslinghuis approved these changes

@ctzsnooze ctzsnooze ctzsnooze approved these changes

@KarateBrot KarateBrot KarateBrot approved these changes

Assignees

@SteveCEvans SteveCEvans

Labels

Ready to Merge RN: BUGFIX

Projects

None yet

Milestone

4.4

Development

Successfully merging this pull request may close these issues.

DPS310 bad readings over time.

5 participants

@SteveCEvans @blckmn @ctzsnooze @haslinghuis @KarateBrot