Skip to content

Fix BLHeli32 Serial Passthrough #12016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 22, 2022
Merged

Fix BLHeli32 Serial Passthrough #12016

merged 1 commit into from
Nov 22, 2022

Conversation

@benjamind2
Copy link
Contributor

@benjamind2 benjamind2 commented Nov 22, 2022

Betaflight's passthrough for the BLHeliSuite requires USE_SERIAL_4WAY_BLHELI_INTERFACE to be defined and it's gated on USE_PWM_OUTPUT.

This PR checks and sets USE_PWM_OUTPUT before it's used to configure USE_SERIAL_4WAY_BLHELI_INTERFACE.

@benjamind2
Fix BLHeli32 Serial Passthrough
8256b3c 
Define USE_PWM_OUTPUT before checking if it's enabled.
@haslinghuis haslinghuis added Cleanup RN: IGNORE This issue / pull request will be ignored in release note generation Cloud Build labels Nov 22, 2022
@haslinghuis haslinghuis added this to the 4.4 milestone Nov 22, 2022
@github-actions
Copy link

github-actions bot commented Nov 22, 2022

Do you want to test this code? Here you have an automated build:
Assets
WARNING: It may be unstable. Use only for testing! See: https://www.youtube.com/watch?v=I1uN9CN30gw for instructions for unified targets!

@blckmn
Copy link
Member

blckmn commented Nov 22, 2022

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> FAIL
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> FAIL
  • approver count at least three -> FAIL

@blckmn blckmn merged commit 4fb1222 into betaflight:master Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@blckmn blckmn blckmn approved these changes

@haslinghuis haslinghuis haslinghuis approved these changes

@KarateBrot KarateBrot KarateBrot approved these changes

Assignees

No one assigned

Labels

Cleanup Cloud Build RN: IGNORE This issue / pull request will be ignored in release note generation

Projects

None yet

Milestone

4.4

Development

Successfully merging this pull request may close these issues.

4 participants

@benjamind2 @blckmn @haslinghuis @KarateBrot