SmartAudio Lite compatibility: Send 0x00 bit(s) (always) even with Soft Serial. #7603
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been sitting on this for a while. Basically, I noticed that with the my AIKONF4's which expose a 'vtx' control pad on SoftSerial with SmartAudio Lite on the TBS Unify Nano (genuine), that it would sit in autobaud state.
I hacked this up to send the extra 0x00's all the flippin time, and it seems to work enough to be usable. As the configurable UART support we have discussed (inversion, pull-down/pull-up, baud, stopbits, blahblah) internally has not yet surfaced.. here's a hack instead.
I'm personally not in favour of a 10k hard pull down workaround - I have always run the patch to avoid it - and the latest revision of TBS SA spec document calls for the host MCU to pull the line low if the hard pull down can not be 100% guaranteed. One could make the argument that the host should also be SA protocol-standards compliant to best effort: we cannot ensure the hard-pull down, i.e. we must pull the line low (as even if a hard pull-down existed, it would effectively be idempotent) in all configurations.
The major downside of this change is that it obviously 💇♂️ supports their license non-compliant competitor e.g. early AKK/Mach2 drama-llama variants.