[H7] Fix ADC DMA buffer transposing bug #9367
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikeller
requested changes
Jan 15, 2020
src/main/target/NUCLEOH743/target.h
Outdated
Member
There was a problem hiding this comment.
If this if final then the conditional should be removed.
Contributor
Author
There was a problem hiding this comment.
Doh! It's a test config. Will remove it.
jflyper
force-pushed
the
bfdev-h7-fix-adc-dma-buffer-transposing-bug
branch
from
15cf52d to
456f5a9
Compare
mikeller
approved these changes
Jan 16, 2020
mikeller
added a commit
that referenced
this pull request
Jan 16, 2020
[H7] Fix ADC DMA buffer transposing bug
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9344
EDIT
This bug probably needs some explanation.
As H7's DMA buffer coherency management is done with MPU regions, it is necessary to attribute DMA buffer as appropriate. When I've done this, I somehow came to believe that
drivers/adc.cshould be free from DMA details and decided NOT to attributeadcValuesas DMA buffers, and transposing be done in H7 specific code (hence the current implementation ofadcGetChannelValues()that transpose elements). The actual transposing is done inadcGetChannel()indrivers/adc.c, which resulted in extra transposing. This PR removes the extra transposing inadcGetChannelValues()and just do a active element transfer, but a better solution may be to attributeadcValuesas DMA buffer and removeadcGetChannelValues()woes (which actually is inefficient as it is called for each separate value is requested byadcGetChannel()).