Skip to content

Added POSITION HOLD flight mode show #788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 8, 2024
Merged

Added POSITION HOLD flight mode show #788

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/flightlog_fielddefs.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,7 @@ export const FLIGHT_LOG_FLIGHT_MODE_NAME_POST_4_5 = makeReadOnly([
"HEADFREE",
"PASSTHRU",
"FAILSAFE",
"POSHOLD",
Copy link
Member

@haslinghuis haslinghuis Dec 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think we need to revisit FM's added from 4.5. and add them instead to

https://github.com/betaflight/blackbox-log-viewer/pull/788/files#diff-1c35af2d073b48014296ed8da03ed89c112f28d05456355d2bf04f3fb3e92ce4R538-R540

Copy link
Contributor Author

@demvlad demvlad Dec 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have new AltHold and PosHold modes after 4.5. Its are included in modes list now.

Copy link
Member

@haslinghuis haslinghuis Dec 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These flight modes were added in 4.6. Are they backwards compatible using 4.5 logs ?

Copy link
Contributor Author

@demvlad demvlad Dec 8, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new AltaHold and PosHold modes names are added for BF 4.6 FW versions only.
The previouse BF versions logs use its own names list.

"GPSRESCUE",
"ANTIGRAVITY",
"HEADADJ",
Expand Down