recovery fallback image#23433
Merged
alice-i-cecile merged 3 commits intobevyengine:mainfrom Mar 22, 2026
Merged
Conversation
atlv24
added
A-Rendering
IceSentry
reviewed
Mar 20, 2026
tychedelia
approved these changes
Mar 22, 2026
IceSentry
approved these changes
Mar 22, 2026
IceSentry
added
S-Ready-For-Final-Review
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 22, 2026
# Objective - Continue Render Recovery efforts #23350 #22761 #23433 #23458 - Part of goal #23029 - make indirect parameter buffers and batched instance buffers reinitalize on recovery ## Solution - split out the stuff that shouldnt be reinitialized from them - use init_gpu_resource ## Testing - examples run - in combination with the rest of the fixes and a couple other local changes i havent PRd yet, render_recovery example works.
This was referenced Mar 22, 2026
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 22, 2026
# Objective - Continue Render Recovery efforts #23350 #22761 #23433 - Part of goal #23029 ## Solution - Clear view upscaling pipelines on reload ## Testing - existing examples run fine. render_recovery example does not work yet, but in combination with the other fixes and some not-yet-PR'd fixes this is a load bearing change needed for it to work --------- Co-authored-by: IceSentry <IceSentry@users.noreply.github.com>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 22, 2026
# Objective - Continue Render Recovery efforts #23350 #22761 #23433 #23458 #23459 - Part of goal #23029 - Make shaders work after reload ## Solution - This is a kinda ugly hack. I explored like 5 different ways of doing this, none of them are satisfying and they are all much larger diffs than this. The crux of the problem is that the composer's capabilities may differ on the new device, due to switching from dedicated to integrated GPU. This means that we cannot even retain the composed modules. The ShaderCache and PipelineCache are quite annoyingly tangled, and I have some glimpses of how to fix it in the future but I dont want to block render recovery on it. - For now, we just do the kinda brute force thing and reinsert all the shaders, recompose etc ## Testing - examples run - in combination with the rest of the fixes and a couple other local changes i havent PRd yet, render_recovery example works.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 22, 2026
# Objective - Continue Render Recovery efforts #23350 #22761 #23433 #23458 #23459 #23461 - Part of goal #23029 - Make render assets exist again after reload ## Solution - We re-extract everything from the main world. This assumes things *exist* on the main world, which is not actually always true. This is enough for most examples and simple usage to be recoverable, but it's really butting up against bevy_asset deficiencies. The next step to making this truly production grade is asset streaming, which will probably be my next goal. ## Testing - examples run - in combination with the rest of the fixes, render_recovery example works.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 23, 2026
# Objective - Completes goal and closes #23029 - Culmination of #22761, #23350, #23349, #23433, #23458, #23444, #23459, #23461, #23463, #22714, #22759, #16481 ## Solution - Add a release note. - Re-export a wgpu type that you need to match on to handle errors. ## Testing - cargo run --example render_recovery with all the other PRs merged in. Press 5 and then V, the app will not crash. Note that D for "destroy device" will still crash: this is a WGPU problem resolved by gfx-rs/wgpu#9281. # Note I opted not to change the default recovery behavior yet. I believe we need testing in user projects and just general trodding of this code path before committing to a new default. It works in a simple example, it might not work in a complex project. We need to field test this and likely iterate to really call this ready IMO.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Solution
Testing