Create mesh view bind group layout on demand to remove unused bindings#23982
Merged
alice-i-cecile merged 17 commits intobevyengine:mainfrom May 1, 2026
Merged
Create mesh view bind group layout on demand to remove unused bindings#23982alice-i-cecile merged 17 commits intobevyengine:mainfrom
alice-i-cecile merged 17 commits intobevyengine:mainfrom
Conversation
IceSentry
reviewed
Apr 25, 2026
IceSentry
reviewed
Apr 25, 2026
Contributor
IceSentry
left a comment
IceSentry
left a comment
There was a problem hiding this comment.
Could the logic to create the offsets array be pulled out to a separate system that runs before the various render commands and stores it in as a component on the view? That way it doesn't need to be copy pasted everywhere.
kfc35
added
C-Bug
kfc35
added
the
P-Regression
kfc35
reviewed
Apr 25, 2026
Contributor
There was a problem hiding this comment.
Thank you for doing this!
I tested it with the 3d_scene example as described and it is no longer broken for me.
This does not fix #23975 but that’s a separate issue. (This PR reduces the sampled textures to 17. I also get some other validation error about dynamic offsets: BindGroup with 'mesh_view_bind_group' label 0 expects 4 dynamic offsets. However 5 dynamic offsets were provided.) That can be a separate PR (and probably should be separate to keep this PR less complicated).
Add MeshViewLayoutKey component Reuse heap allocation in `prepare_mesh_view_bind_groups` Remove contact shadows offset and distance fog offset if disabled
beicause
force-pushed
the
mesh-view-rm-unused-binding
branch
2 times, most recently
from
8331905 to
059affa
Compare
beicause
force-pushed
the
mesh-view-rm-unused-binding
branch
from
059affa to
b3e7359
Compare
alice-i-cecile
added
the
D-Modest
kfc35
approved these changes
Apr 26, 2026
Contributor
kfc35
left a comment
kfc35
left a comment
There was a problem hiding this comment.
Thank you for consolidating! It feels cleaner
Co-authored-by: Kevin Chen <chen.kevin.f@gmail.com>
Zeophlite
approved these changes
Apr 28, 2026
HackerFoo
approved these changes
Apr 29, 2026
Contributor
|
This looks good and cleans up a lot of the code I've been working with. |
Zeophlite
added
S-Ready-For-Final-Review
jvastola
pushed a commit
to jvastola/bevy
that referenced
this pull request
May 3, 2026
…g `MeshPipelineViewLayoutKey` (bevyengine#24090) # Objective - Related bevyengine#24084 - Fixes `atmosphere` example after merging bevyengine#23982 ## Solution - As @beicause mentioned, volumetric frog was calculating `MeshPipelineViewLayoutKey` manually when it could just rely on the `ViewKeyCache` instead, which has centralized logic for calculating it in `check_views_need_specialization` (`STBN` is added in `impl From<MeshPipelineKey> for MeshPipelineViewLayoutKey`) ## Testing - `cargo run --example atmosphere` works now, no strobing! - `cargo run --example volumetric_fog` also works - `cargo run --example scrolling_fog` works
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Fixes #23627.
MeshPipelineViewLayoutKeyuses too many bindings even if features like ssr, environment map are unused.Solution
Don't pre-allocate every combination that grows exponentially. Instead, create mesh view bind group layout on demand so that we can add more view keys to reduce unused bindings.
MeshPipelineViewLayouts::get_view_layoutwill be slower, but I'm not sure how slow it is. My feeling is that the overhead is not high, compared to when we clone it before.Testing