Fix: use ViewKeyCache in volumetric fog instead of manually creating MeshPipelineViewLayoutKey#24090
Merged
alice-i-cecile merged 1 commit intobevyengine:mainfrom May 3, 2026
Conversation
…MeshPipelineViewLayoutKey
beicause
approved these changes
May 3, 2026
JMS55
approved these changes
May 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
atmosphereexample after merging Create mesh view bind group layout on demand to remove unused bindings #23982Solution
MeshPipelineViewLayoutKeymanually when it could just rely on theViewKeyCacheinstead, which has centralized logic for calculating it incheck_views_need_specialization(STBNis added inimpl From<MeshPipelineKey> for MeshPipelineViewLayoutKey)Testing
cargo run --example atmosphereworks now, no strobing!cargo run --example volumetric_fogalso workscargo run --example scrolling_fogworks