Speed up project branch loading and recover unavailable GitLab discovery - #20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Projects returned 502 when the provider hid repository discovery because no current GitLab connection was usable. The specific validated Describe NotFound result now returns an empty repository list, allowing Devcenter to offer normal reconnection. Authentication, transport, malformed envelopes and provider invocation failures remain errors.
Branch listing and selection repeatedly scanned the membership repository catalogue. They now describe and invoke the existing gitlab-branch-list operation for the already revalidated exact numeric project and current connection, requesting 100 branches per page until completion. Later-page failures and malformed responses cannot produce partial success. Public client contracts and materialization policy are unchanged.
Validation: regression tests failed before both repairs and passed afterward; 56 workspace-service package tests, including 17 new recovery/branch cases; the complete task check passed 59 Cargo tests plus 20 release-policy/adversary cases, formatting and full-workspace Clippy with warnings denied. The independent adversarial pass found no defect and is recorded verbatim in the owning story. Workspace runtime release 0.2.20 carries the fix independently of its unchanged client API.