fix(standards): the sticky capture date was rewritten on every run - #296
Merged
Conversation
Ports to develop the bug found while bringing the same design to main (#295). `classificationChanged` compared `JSON.stringify(previous.counts)` against a counts object rebuilt in KNOWN_CLASSES order, while the renderer emits them in CLASS_ORDER — a different order for the same six numbers. So it always reported "changed", `capturedOn` was refreshed on every run, and the GT-630 fixed-point replay would have failed on any day after a capture. WHY IT WAS INVISIBLE HERE. The reconciliation (#294) landed and was verified on the same day the snapshot was captured, so both runs stamped 2026-07-30 and the bytes matched. A green that depends on the date being unchanged is exactly the kind this chain exists to distrust. It surfaced on main only because that branch's committed snapshot carried 2026-07-29, so the two runs disagreed out loud. OBSERVED BOTH WAYS rather than declared, by forcing the committed date to 2026-07-28 and running the capture with the classification unchanged: without the fix -> capturedOn becomes 2026-07-30 (drift) with the fix -> capturedOn stays 2026-07-28 (sticky, as designed) Verified after restoring the committed snapshot: `--check` passes, the replay is byte-identical, the derived-artifact chain reports 5 links current and at a fixed point, and the ISO/IEC 5055 mapping guard is 9/9. Only the script changed. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
📊 Bilingual Coverage ImpactPR Changes
Repository Coverage
To create skeletons: node .harness/scripts/generate-es-skeleton.mjs <file.md>Generated by GitHub Actions |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports to
developthe bug found while bringing the same design tomain(#295).classificationChangedcomparedJSON.stringify(previous.counts)against a counts object rebuilt inKNOWN_CLASSESorder, while the renderer emits them inCLASS_ORDER— a different order for the same six numbers. So it always reported "changed",capturedOnwas refreshed on every run, and the GT-630 fixed-point replay would have failed on any day after a capture.Why it was invisible here
The reconciliation (#294) landed and was verified on the same day the snapshot was captured, so both runs stamped
2026-07-30and the bytes matched. A green that depends on the date not having changed is exactly the kind this chain exists to distrust. It surfaced onmainonly because that branch's committed snapshot carried2026-07-29, so the two runs disagreed out loud.Observed both ways, not declared
Forcing the committed date to
2026-07-28and running the capture with the classification unchanged:capturedOnafter the run2026-07-30— drift2026-07-28— sticky, as designedVerified after restoring the committed snapshot
--checkpasses · the replay is byte-identical · derived-artifact chain reports 5 links current and at a fixed point · ISO/IEC 5055 mapping guard 9/9. Only the script changed.Evolith Core Quality Gates
reference/touched.Linked ADRs / Issues
Conventional Commits
🤖 Generated with Claude Code