feat(products): composable multi-dimensional topology in the domain (CR-08)#35
Merged
Merged
Conversation
…CR-08, ADR-0079)
Brings the composed topology model into the domain instead of a single Topology string. New authoritative TopologyCatalog (5 dimensions + composableWith rules) and TopologySet value object: hard validation mirrors the frontend validateTopologySet (required dimensions present + topology valid for its dimension; UnknownDimension/InvalidTopologyForDimension/MissingRequiredDimension), with composability surfaced as non-blocking CompositionWarnings so canonical blueprint sets stay valid. Product gains a TopologySet prop + SetProductTopologySet (derives the legacy Topology from progressive-axis); persisted as jsonb topology_set via an additive migration AddProductTopologySet; new POST /{id}/topology-set endpoint. Build Release -warnaserror 0 warnings; 458->473 tests. Marks CR-08 DONE (Core sync deferred on GAP-004; unifying the Presentation static catalog with TopologyCatalog is a noted follow-up).
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings the ADR-0079 composed topology model into the domain (was a single
Topologystring).TopologyCatalog(authoritative: 5 dimensions + composableWith) +TopologySetVO — hard validation mirrors the frontend (required dims + valid-per-dimension); composability is non-blockingCompositionWarningsso canonical blueprint sets stay valid.Product.SetProductTopologySet(derives legacyTopology), jsonbtopology_set+ additive migrationAddProductTopologySet,POST /{id}/topology-set.Build
-warnaserror0 warnings; 458→473 tests. Closes CR-08 (Core sync deferred on GAP-004).🤖 Generated with Claude Code