Fixed frustum culling for 2D shape light falloff offset#1
Open
bezzgames wants to merge 1 commit into
Open
Conversation
Fixed the boundary sphere calculated for the 2d shape lights. This sphere now takes into account the falloff offset that controls the light direction. This fixes invalid culling when only the falloff is in view.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed the boundary sphere calculated for the 2d shape lights. This sphere now takes into account the falloff offset that controls the light direction.
This fixes invalid frustum culling when only the falloff is in view.
Purpose of this PR
This pull request will fix issues with 2d shape lights being culled too early.
Release Notes
Fixed frustum culling on 2d shape lights with falloff offsets.
Manual Tests: What did you do?
Overall Product Risks
Technical Risk: Low