mage-flow: add FFN checkpointing logic - #2907
Merged
bghira merged 6 commits intoJul 27, 2026
Merged
Conversation
added 5 commits
July 25, 2026 09:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements and new tests for the MageFlow Transformer model, focusing on enhanced gradient checkpointing flexibility, support for feed-forward network (FFN) checkpointing, and increased test coverage for attention and packing logic.
MageFlow Transformer Model Enhancements
_supports_ffn_gradient_checkpointingflag and handling a newgradient_checkpointing_scopeparameter. This allows selective checkpointing of feed-forward layers, improving memory efficiency during training. [1] [2] [3] [4]get_checkpoint_backend_scope, ensuring the correct checkpointing scope is used throughout the model. [1] [2] [3]Test Coverage Improvements
test_mageflow_attention_joint_pack_uses_single_flash_dtype) to verify that the MageFlow attention processor correctly enforces a single dtype (bfloat16) for all projections and outputs, ensuring consistency and preventing dtype mismatches in flash attention. [1] [2]test_pack_latents_tracks_rectangular_target_shape) to validate that the model's latent packing logic correctly tracks and returns the expected shapes, indices, and lengths for rectangular targets, increasing reliability of input handling.