Update computer keyboard controller to use key codes#7
Merged
Conversation
Release 0.4.1
Add a new computer keyboard handler to play notes based on key codes. This adds support for non-QWERTY keyboard layouts.
We may get stop note calls from a computer keyboard controller if a user presses a modifier key, presses a playable key while holding the modifier key, releases the modifier key, and finally releases the playable key. We might be able to handle this in the controller code, but this option is simpler and works for now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the computer keyboard controller to use key codes (https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent/code). The change maps notes to the physical key on the keyboard instead of character values. This adds support for non-QWERTY keyboard layouts.