Merged
Conversation
Add a new computer keyboard handler to play notes based on key codes. This adds support for non-QWERTY keyboard layouts.
We may get stop note calls from a computer keyboard controller if a user presses a modifier key, presses a playable key while holding the modifier key, releases the modifier key, and finally releases the playable key. We might be able to handle this in the controller code, but this option is simpler and works for now.
Update computer keyboard controller to use key codes
We can keep the key subscription when we are only updating the instrument. This means we also explicitly nullify the key subscription when we switch to use another controller.
Held notes would hang when switching patches or changing the controller. The changes here call stop note on each held note, gracefully stopping the notes and loading the patch or setting the new controller. Also a fix here to remove MIDI listeners when changing to the keyboard controller.
Leave the console log for note frequency as it might be useful to users examining a microtuning.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This release adds support for non-QWERTY keyboard layouts and fixes an issue where held notes would not release when changing the patch or controller.
It also updates the initial document title, removes debugging statements, and clarifies the copy on the homepage.