Skip to content

Fix RPKI Archive Repo Name Typo#120

Merged
digizeph merged 2 commits intobgpkit:mainfrom
daknob:fix-sobornost-typo
Mar 21, 2026
Merged

Fix RPKI Archive Repo Name Typo#120
digizeph merged 2 commits intobgpkit:mainfrom
daknob:fix-sobornost-typo

Conversation

@daknob
Copy link
Copy Markdown
Contributor

@daknob daknob commented Mar 20, 2026

RPKIViews' default source is Job's server under the sobornost domain name: josephine.sobornost.net.

Unfortunately, throughout bgpkit soborost is used.

This PR fixes all instances and corrects the typo across the git repo. However, this means that whoever was using this with the previous typo will face a breaking change.

Since this was the default value I think there aren't probably any users that had this hardcoded explicitly, but do you think it would make sense to have a second value map to the correct internal RpkiViewsCollectorOption ? I can modify this PR to do it, it should be a couple of minutes.

@daknob
Copy link
Copy Markdown
Contributor Author

daknob commented Mar 20, 2026

I forgot to send the other PR, that's why it failed, the typo extends beyond this repo :)

@digizeph
Copy link
Copy Markdown
Member

@daknob Thank you for catching it! Based on the build result, another upstream library (bgpkit-commons) also share this typo. Let me update it first, and then merge this PR.

@digizeph digizeph merged commit 9801291 into bgpkit:main Mar 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants