Make zparseopts section argument extraction more robust#2
Merged
bgreg merged 2 commits intoDec 22, 2025
Conversation
5 tasks
Use last element instead of hardcoded index 2, add validation for array length, and provide clear error message when --section value is missing. Co-authored-by: bgreg <3711139+bgreg@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Address feedback on weather geolocation and offline word of day
Make zparseopts section argument extraction more robust
Dec 22, 2025
bgreg
added a commit
that referenced
this pull request
Mar 31, 2026
Make zparseopts section argument extraction more robust
bgreg
added a commit
that referenced
this pull request
Jun 30, 2026
Make zparseopts section argument extraction more robust
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
zparseoptssyntax-section:=section_argpopulates an array with both option name (index 1) and value (index 2). Hardcodingsection_arg[2]is fragile if zparseopts behavior changes.Changes:
section_arg[-1]to extract the last element instead of hardcoded index 2--sectionis provided without a value💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.