Replace grep-based weather tests with runtime behavior tests

[Copilot]

The weather function tests only verified source code strings via grep, not actual runtime behavior.

Changes

• Replaced grep tests with integration tests: Mock fetch_with_spinner to test actual function execution instead of searching source code
• Added 6 behavioral test cases:
  • Early return when location unset
  • Successful weather fetch
  • "Not found" API response → fallback message
  • Empty API response → fallback message
  • URL construction includes location variable
  • Correct curl parameters (flags, timeout, URL format)

Implementation

Tests now mock at the fetch_with_spinner layer rather than curl directly, avoiding subshell scoping issues:

# Before: grep for strings in source
It 'uses location in wttr.in URL'
  When call grep 'wttr.in/\${location}' "$PROJECT_ROOT/lib/app/display.sh"
  The output should not be blank
End

# After: verify runtime behavior
It 'uses location in wttr.in URL construction'
  fetch_with_spinner() {
    shift
    for arg in "$@"; do
      [[ "$arg" == *"wttr.in/New_York"* ]] && echo "New York 🌧️ +65°F" && return 0
    done
    return 1
  }
  GOODMORNING_WEATHER_LOCATION="New_York"
  When call show_weather
  The output should include "🌧️"
End

All 24 tests in display_spec.sh pass.

---

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

[Copilot]

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

• esm.ubuntu.com
  • Triggering command: /usr/lib/apt/methods/https /usr/lib/apt/methods/https (dns block)
• git.io
  • Triggering command: /usr/bin/curl curl -fsSL REDACTED (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

• Configure Actions setup steps to set up my environment, which run before the firewall is enabled
• Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)