Freeze the practical v0 completion contract - #135
Conversation
alexlopashev
left a comment
There was a problem hiding this comment.
Independent review task identity: /root/review_pr_88
Reviewed exact head 58d5c7ea6bb1aa08bdd5b18434c7261213874f31 against current origin/main, issue #99, SEMANTICS, the v0 wire contract, conformance catalog, CI test plan, and public documentation.
The inventory/counting portion is coherent: the focused completion-contract test and CI-plan test pass, the 99 expanded scenario IDs match the normative catalog, all 17 wire roots are present, the hosted target is assigned exactly once, and the protected checks are green. However, the reference artifacts are not a valid frozen future end-to-end subject, and the current validator accepts those semantic contradictions through substring checks. The inline findings are merge blockers.
Validation performed:
cargo test --test v0_completion_contract: 3/3 passedcargo test --test ci_workflow: 6/6 passed- Existing public policy CLI against the frozen policy: rejected at line 3 with
BHCP8001: limit policy value dimension must be a symbol-id git diff --check: clean
This is a review comment rather than an approval because the GitHub account is shared.
alexlopashev
left a comment
There was a problem hiding this comment.
Independent re-review task identity: /root/review_pr_88
Re-reviewed exact head 72e0932dbebdaddf128f07f46b01218adc6c089a against current origin/main, issue #99/#132, SEMANTICS S3–S10, the v0 schema/model boundary, conformance catalog, CI plan, and AGENTS.md.
Two prior P1s are resolved and their threads were closed:
- the policy now uses canonical typed values and passes the public parser/composer;
- obligations use valid obligation states, with operational outcomes separated into the eight-case matrix.
Focused evidence:
cargo test --test v0_completion_contract: 4/4 passedcargo test --test ci_workflow: 6/6 passed- public policy composition: passed
git diff --check: clean
The replacement still is not a valid frozen end-to-end target. Three semantic blockers and the validator gap are recorded inline. The program/feature/validator threads remain unresolved. I did not approve or merge; the shared GitHub account cannot provide independent author approval.
alexlopashev
left a comment
There was a problem hiding this comment.
Independent re-review task identity: /root/review_pr_88
Re-reviewed exact head d220bbb. The four findings from review 4737396985 are materially addressed: direct Boolean bounds and a decreasing recursion measure are frozen; reducer/lowerer signatures and all five rule content references are present; exact effect IDs and effective goal scopes now agree; the waiver engine actually produces ceiling 3; and the policy-evidence mapping is explicit.
Focused evidence passes: v0_completion_contract 4/4, ci_workflow 6/6, public policy composition, and git diff --check. Protected checks are still completing.
The exact head remains unmergeable because the program/input is not a closed typed subject, the semantic projection can drift from owner-scoped source declarations, and the chain shape conflicts with the normative executable chain slice. Inline P1 findings describe each blocker. I did not resolve threads, approve, or merge.
alexlopashev
left a comment
There was a problem hiding this comment.
Independent re-review task identity: /root/review_pr_88
Re-reviewed exact head 76d4870 against origin/main, issue #99, SEMANTICS S3-S12, the complete reference inventory, and all prior review findings.
The resource/input and S8.1 chain blockers are fixed, and I resolved those plus the genuinely satisfied earlier program/profile/recursion/extension/policy threads. The exact head is unchanged. The canonical local gate passes in full, git diff --check is clean, public policy composition passes, and every protected check is green.
One semantic-projection blocker remains inline. The new owner-scoped checks are one-way: they validate only rows already present in the hand-authored projection, so source obligations, type-definition shapes, and extra facts can still drift without rejection. I kept the validator threads unresolved and did not approve or merge. This is a review comment because the GitHub account is shared with the author.
alexlopashev
left a comment
There was a problem hiding this comment.
Independent re-review task identity: /root/review_pr_88
Re-reviewed exact head 2e1264e. The three concrete mutations from comment 3616531482 are now rejected with the projection fixed: deleting Persist stored fails the clause inventory, changing Delivery.sequence Text to Bool fails the definition digest, and adding a StartDelivery input fails the typed-fact inventory. The complete canonical local gate passes, git diff --check is clean, policy composition passes, all protected checks are green, and the remote head remains exact.
I did not resolve comment 3616531482, approve, or merge because the new source commitment still omits unrecognized top-level constructs. The inline P1 shows a concrete bypass that changes the source while preserving every recorded definition digest and inventory row. This is a review comment because the GitHub account is shared with the author.
alexlopashev
left a comment
There was a problem hiding this comment.
Independent re-review task identity: /root/review_pr_88
Re-reviewed exact head 55b3bd7. The requested unindented between-definition insertions for waiver, policy, syntax, and unknown top-level forms are now rejected by the same closed-kind branch; the focused test and complete canonical local gate pass, git diff --check is clean, and the remote head is unchanged.
I did not resolve comment 3616613966, approve, or merge. The latest fix still scans only column-zero § lines and the hashes start at the first recognized marker, leaving a leading-whitespace top-level construct before the first definition uncommitted. That concrete fail-open case is inline. Two protected shards were still running when this review was recorded; every completed check was green. This is a review comment because the GitHub account is shared with the author.
alexlopashev
left a comment
There was a problem hiding this comment.
Independent final re-review task identity: /root/review_pr_88
Reviewed exact head 73d7095da24d0169776b80e295693934182a3b05 against current origin/main, the complete PR diff, all prior findings, and the source/projection fail-closed boundary. No actionable findings remain.
The exact indented prefix mutation with program-contract.txt fixed now fails on the raw whole-source digest. Independent SHA3-512 calculation matches the reviewed commitments for all 4,217 bytes of program.bhcp and all 885 bytes of extension.bhcp; duplicate, omitted, extra, or altered file-hash rows are rejected by exact map equality. The alternate presentation remains exact through its fixed preamble and exact mapped-body equality.
Evidence: focused mutation test passed; the canonical local gate (fmt, clippy with warnings denied, all targets, release build, schema fixtures) passed; git diff --check is clean; every protected check is green; and the remote head remains exact. The cumulative validator threads are materially satisfied. This is a comment review because the GitHub account is shared with the author; the independent reviewer identity is recorded here.
Closes #99
Outcome
Red-to-green evidence
mise exec -- cargo test --test v0_completion_contractfailed all three initial tests because the completion manifest and reference-program artifacts did not exist.cargo test --all-targetscaught the new target missing from the hosted test partition plan.v0_completion_contractto the semantic/conformance shard.Review resolution
bhcp/meta.network-shape@0lowerer, and five byte-exact SHA3-512-bound rule artifacts.Full validation
mise exec -- cargo fmt --checkmise exec -- cargo clippy --all-targets -- -D warningsmise exec -- cargo test --all-targetsmise exec -- cargo build --releasemise exec -- cargo test --test schema_fixturesgit diff --checkAll passed at the exact head below.
Documentation impact
Residual risk
Head SHA: 73d7095