Parse complete v0 definitions - #136
Conversation
alexlopashev
left a comment
There was a problem hiding this comment.
Independent review task identity: /root/review_pr_88
Reviewed exact head 73a33c6b48c2f3aee12dd74740b0388ab1076044 against SEMANTICS.md S3–S7, issue #100, the canonical AST boundary, existing profile/policy compatibility, and the full PR diff.
The focused parser/policy/profile/completion suites pass, the complete canonical local gate passes, git diff --check is clean, all hosted checks are green, and the remote head remained exact. However, adversarial binder probes show two accepted sources whose local binders are silently captured by built-in/literal parsing, violating alpha-renaming and reserved-keyword requirements. The inline P1 findings are merge blockers. I did not approve or merge; the shared GitHub account cannot supply author-independent approval.
alexlopashev
left a comment
There was a problem hiding this comment.
Independent exact-head re-review by /root/review_pr_88 at c078e4a: no remaining actionable findings.
Verified both prior P1 findings are fixed by the closed reserved-binder check. Independent probes reject built-in/literal capture in type parameters, function and predicate parameters, verifier argument names, refinement binders, and effect-row tails with BHCP1001; an ordinary <T>(value: T): T = value case succeeds and retains parameter-shaped AST nodes.
Focused parser, policy parser, profile-formatting, and v0 completion-contract tests pass. The complete canonical local gate passes (cargo fmt --check, strict all-target Clippy, all-target tests, release build, and schema fixtures), git diff --check is clean, and all hosted checks are green for this exact head.
Closes #100
Outcome
Red-to-green evidence
Initial red: mise exec -- cargo test --test pipeline complete_definition_forms_build_a_closed_schema_valid_ast -- --exact failed at definitions.bhcp:1:58 with BHCP0001 unexpected character ?.
Review red: generic Text and value true could be declared as binders but resolved as a primitive/literal instead. Exact regression cases now reject both declarations with BHCP1001 reserved-spelling diagnostics, while ordinary T retains a parameter-shaped result AST.
Green focused:
Full validation
All passed on exact head c078e4a.
Documentation impact
README now distinguishes complete parser/AST coverage from the deliberately deferred checker and semantic-IR elaboration work.
Residual risk
The complete expression and pattern calculus, general checking, and function/predicate/verifier elaboration remain intentionally blocked into #104, #103, and #105. Newly parsed definitions therefore fail closed with BHCP2004 if executable lowering is requested.