feat: add pane add/remove lifecycle hooks with veto support#101
Merged
Conversation
This was referenced Jun 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds overridable lifecycle hooks around pane add/remove on the frame, wired through
BinaryWindow.What changed
src/frame/pane.js: addonBeforePaneAdd/onPaneAdd/onBeforePaneRemove/onPaneRemovehooks (no-op by default, meant to be overridden). Thebefore*hooks can veto by returningfalse—addPanereturnsnullandremovePanebails.onPaneRemovefires afterupdate(), whensash.domNodestill exists but is detached from the DOM.src/binary-window/binary-window.js:addPaneshort-circuits tonullwhen the underlying add is vetoed;removePanesimplified to always delegate then clean up any minimized sill pot.dev/window/bwin-add-remove-panes.{html,js}: demo the new hooks and default the Sash ID input tobottom-left.Why
Lets downstream code observe and veto pane add/remove, and run cleanup on removal while the detached node is still reachable.