fix: create sill pot after removePane so minimize keeps the pot#103
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Minimizing an attached glass produced no sill pot, so the glass couldn't be restored.
Why
Regression from #101, which removed the live-pane guard in
BinaryWindow.removePane. The minimize action planted the pot before callingremovePane, andremovePane's pot-cleanup (matching onsash-id) then destroyed the pot it had just planted.Fix
Reorder
action.minimize.jsto callremovePanefirst, then create the pot. After removal there's no matching pot for the cleanup to delete, so the freshly planted pot survives.binary-window.jsis left untouched.