Skip to content

fix: create sill pot after removePane so minimize keeps the pot #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ohxyz merged 1 commit into from
Jun 27, 2026
Merged

fix: create sill pot after removePane so minimize keeps the pot #103

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions src/binary-window/glass/action.minimize.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,19 +9,20 @@ export default {
const sillEl = binaryWindow.sillElement;
if (!sillEl) throw new Error(`[bwin] Sill element not found when minimizing`);

const potEl = createDomNode('<button class="bw-pot" bw-plant="glass" />');
sillEl.append(potEl);

const paneEl = event.target.closest('bw-pane');
const glassEl = event.target.closest('bw-glass');
const paneSashId = paneEl.getAttribute('sash-id');
const panePosition = paneEl.getAttribute('position');

binaryWindow.removePane(paneSashId);

// Create the "pot" after `removePane`, which destroys the removed pane's pot
const potEl = createDomNode('<button class="bw-pot" bw-plant="glass" />');
potEl.bwGlassElement = glassEl;
potEl.bwOriginalPosition = panePosition;
potEl.bwOriginalBoundingRect = getMetricsFromElement(paneEl);
potEl.bwOriginalSashId = paneSashId;

binaryWindow.removePane(paneSashId);
sillEl.append(potEl);
},
};