feat: drive detached glass open/close via [opening]/[closing] attributes#89
Merged
Conversation
…imateOpen/animateClose opts Move the open animation from an unconditional rule onto an [opening] attribute set in JS (cleared on animationend), mirroring the existing [closing] close path. Replace the close timeout with an animationend listener. Expose animateOpen on addDetachedGlass/addWindowlessGlass and animateClose on the remove APIs; attach skips the close animation since the glass is moved, not dismissed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reworks the detached-glass open/close animations to be attribute-driven and JS-controllable.
What changed
&[opening]selector;animateDetachedGlassOpen()sets[opening]and clears it onanimationend(so it can replay on restore-from-sill).animationendinstead of a hardcodedsetTimeoutduration (drops theDETACHED_GLASS_CLOSE_DURATIONconstant).animateOpenonaddDetachedGlass/addWindowlessGlass, andanimateCloseon the remove APIs — both defaulttrue.animateClose: false): the glass is moved into a pane, not dismissed, so the emptied husk no longer fades out.Notes
Branch is based off
mainand contains animation changes only — independent of the in-progress drag-and-drop refactor.