refactor: detached glass manager only tracks/unregisters, callers own DOM removal#90
Merged
Merged
Conversation
… DOM removal - removeDetachedGlassByElement just unregisters; drops the animateClose option and the removeDetachedGlassElement call. - close action and removeWindowlessGlass now call removeDetachedGlassElement directly for the animated DOM removal. - Rename manager's `glasses` -> `detachedGlassElements`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Narrows
DetachedGlassManagerto registry/z-index concerns; DOM removal (and its close animation) now lives with the callers.What changed
removeDetachedGlassByElementjust unregisters now — dropped theanimateCloseoption and theremoveDetachedGlassElementcall.removeWindowlessGlasscallremoveDetachedGlassElement(glassEl, animateClose)directly for the animated DOM removal.glassesarray todetachedGlassElements.Builds on #89.