Skip to content

Conversation

@ubdbra001
Copy link
Contributor

@ubdbra001 ubdbra001 commented Nov 3, 2025

closes #43

Adds type-checking using mypy to the CI with tox.

@codecov
Copy link

codecov bot commented Nov 3, 2025

Codecov Report

❌ Patch coverage is 89.89899% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.56%. Comparing base (92c6852) to head (c3dcb23).

Files with missing lines Patch % Lines
src/bids_validator/context.py 60.00% 7 Missing and 1 partial ⚠️
src/bids_validator/types/_typings.py 71.42% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #46      +/-   ##
==========================================
- Coverage   90.95%   90.56%   -0.40%     
==========================================
  Files          12       13       +1     
  Lines         774      795      +21     
  Branches      116      120       +4     
==========================================
+ Hits          704      720      +16     
- Misses         46       48       +2     
- Partials       24       27       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ubdbra001 ubdbra001 marked this pull request as draft November 3, 2025 16:43
@ubdbra001 ubdbra001 force-pushed the i43-add-mypy branch 7 times, most recently from a8f1548 to 1ce2b4f Compare November 3, 2025 21:21
@ubdbra001
Copy link
Contributor Author

@effigies Here's an initial attempt at adding type-checking using mypy to the CI, though I don't think this is how you envisaged it working. What do you think?

@effigies
Copy link
Contributor

effigies commented Nov 5, 2025

Yup, this looks good to me. Now to start fixing the errors... I may push a few things.

@effigies
Copy link
Contributor

effigies commented Nov 5, 2025

Reenabling strict mode and some initial fixes...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add type checking job

2 participants