Bump tmp and eslint - #13
Conversation
Removes [tmp](https://github.com/raszi/node-tmp). It's no longer used after updating ancestor dependency [eslint](https://github.com/eslint/eslint). These dependencies need to be updated together. Removes `tmp` Updates `eslint` from 6.0.1 to 10.7.0 - [Release notes](https://github.com/eslint/eslint/releases) - [Commits](eslint/eslint@v6.0.1...v10.7.0) --- updated-dependencies: - dependency-name: tmp dependency-version: dependency-type: indirect - dependency-name: eslint dependency-version: 10.7.0 dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
added
dependencies
📝 WalkthroughWalkthroughThe pull request updates the ChangesESLint dependency update
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
ESLint install failed: dependency version conflict. Check your lock file or package.json. Comment |
CI failed: The CI build failed due to an outdated Ruby environment configuration; the project is using a deprecated action and an EOL Ruby version that is no longer available on the runners.OverviewOne failure was identified across all analyzed logs. The build is failing because it relies on a deprecated GitHub Action ( FailuresDeprecated Ruby Environment Configuration (confidence: high)
Summary
Code Review 🚫 Blocked 0 resolved / 2 findingsUpdates ESLint to 10.7.0 and removes the unused 🚨 Bug: ESLint 10 breaks legacy .eslintrc config and lint script📄 package.json:7 📄 package.json:9 📄 package.json:39 The repo's lint config lives in
|
| Auto-apply | Compact |
|
|
Important
Your trial ends in 3 days — upgrade now to keep code review, CI analysis, auto-apply, custom automations, and more.
Was this helpful? React with 👍 / 👎 | Gitar
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
![gitar-bot[bot]](https://avatars.githubusercontent.com/in/827041?s=60&v=4){kind=small}
| "@babel/preset-env": "^7.4.5", | ||
| "@types/jest": "^24.0.15", | ||
| "eslint": "^6.0.1", | ||
| "eslint": "^10.7.0", |
There was a problem hiding this comment.
🚨 Bug: ESLint 10 breaks legacy .eslintrc config and lint script
The repo's lint config lives in .eslintrc (eslintrc format with env and extends: "airbnb"), but ESLint 9 dropped eslintrc as the default and ESLint 10 fully requires flat config (eslint.config.js). After this bump, npm run lint (and the ci/husky hooks that call it) will fail to load the existing config. Migrate to a flat eslint.config.js (e.g. via @eslint/eslintrc's FlatCompat) as part of this upgrade, or the lint step is broken.
Was this helpful? React with 👍 / 👎
| "@babel/preset-env": "^7.4.5", | ||
| "@types/jest": "^24.0.15", | ||
| "eslint": "^6.0.1", | ||
| "eslint": "^10.7.0", |
There was a problem hiding this comment.
⚠️ Bug: eslint-config-airbnb 17 / plugins incompatible with ESLint 10
eslint-config-airbnb@^17.1.0 declares a peer dependency on eslint@^5||^6 (and the pinned eslint-plugin-import, eslint-plugin-jsx-a11y, eslint-plugin-react versions target that era), so pairing it with eslint@^10.7.0 produces peer-dependency conflicts and rule/API mismatches at runtime. Bump the Airbnb config and ESLint plugins to versions that support ESLint 10 alongside this change, rather than upgrading eslint in isolation.
Was this helpful? React with 👍 / 👎
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@package.json`:
- Line 39: Update the ESLint configuration before retaining the ESLint v10
dependency: migrate the existing .eslintrc settings, including AirBnB and Jest
rules, into an eslint.config.* flat configuration that ESLint 10 loads, and
ensure the existing eslint ./src/* command uses those rules.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: c44611f6-7b0e-471e-966f-97d1ba0d74a3
⛔ Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (1)
package.json
| "@babel/preset-env": "^7.4.5", | ||
| "@types/jest": "^24.0.15", | ||
| "eslint": "^6.0.1", | ||
| "eslint": "^10.7.0", |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟠 Major | 🏗️ Heavy lift
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Verify that the ESLint v10 migration is complete without executing repository code.
fd -HI 'eslint.config.*|\.eslintrc.*|package-lock.json|npm-shrinkwrap.json|yarn.lock|pnpm-lock.yaml' .
rg -n '"lint"|"eslint"|"airbnb"|"eslint-plugin-jest"|"engines"' package.json .github 2>/dev/nullRepository: big-main/javascript-algorithms
Length of output: 339
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo '--- package.json (relevant lines) ---'
nl -ba package.json | sed -n '1,80p'
echo
echo '--- .eslintrc ---'
nl -ba .eslintrc | sed -n '1,220p'Repository: big-main/javascript-algorithms
Length of output: 246
🌐 Web query:
ESLint v10 removes eslintrc support migration guide legacy config flat config
💡 Result:
In ESLint v10.0.0, support for the legacy eslintrc configuration format (including.eslintrc files) has been completely removed [1][2]. This major release marks the final transition to the flat configuration format (eslint.config.js) as the only supported way to configure ESLint [2]. Key changes in v10.0.0 include: - The ESLINT_USE_FLAT_CONFIG environment variable is no longer supported and will be ignored [2]. - CLI flags specific to eslintrc (e.g., --no-eslintrc, --env, --ignore-path, --rulesdir) have been removed [2]. - Files such as.eslintrc.* and.eslintignore are no longer honored [2]. - The Linter API no longer supports the eslintrc config type; the configType argument must be set to "flat" [2]. - Deprecated APIs including LegacyESLint, FileEnumerator, and specific Linter methods (e.g., defineRule, defineRules, defineParser) have been removed [2]. To migrate to ESLint v10: 1. Use the official migration tool: ESLint provides an automated migrator to help convert your existing configuration to the flat config format. You can run the configuration migrator on your existing files (e.g.,.eslintrc,.eslintrc.json) to generate an initial eslint.config.js [3]. 2. Utilize Codemods: ESLint offers specialized codemods to assist with the upgrade. The @eslint/v9-to-v10 codemod suite is available to automate many of the necessary changes, including updating API usage and cleaning up deprecated configurations [1]. 3. Consult the Migration Guide: Refer to the official ESLint Migrate to v10.x guide for comprehensive steps to address breaking changes, update your configurations, and resolve API deprecations [1][4].
Citations:
- 1: https://eslint.org/docs/latest/use/migrate-to-10.0.0
- 2: https://eslint.org/blog/2026/02/eslint-v10.0.0-released/
- 3: https://eslint.org/docs/latest/use/configure/migration-guide
- 4: https://github.com/eslint/eslint/blob/main/docs/src/use/migrate-to-10.0.0.md
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo '--- package.json (relevant lines) ---'
sed -n '1,80p' package.json
echo
echo '--- .eslintrc ---'
sed -n '1,220p' .eslintrcRepository: big-main/javascript-algorithms
Length of output: 1828
Migrate the ESLint config before upgrading to v10. .eslintrc is still the only ESLint config here, but ESLint 10 ignores legacy config files, so eslint ./src/* won’t load the AirBnB/Jest rules unless you add an eslint.config.* flat config or keep ESLint on a legacy-supported version.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@package.json` at line 39, Update the ESLint configuration before retaining
the ESLint v10 dependency: migrate the existing .eslintrc settings, including
AirBnB and Jest rules, into an eslint.config.* flat configuration that ESLint 10
loads, and ensure the existing eslint ./src/* command uses those rules.
Removes tmp. It's no longer used after updating ancestor dependency eslint. These dependencies need to be updated together.
Removes
tmpUpdates
eslintfrom 6.0.1 to 10.7.0Release notes
Sourced from eslint's releases.
... (truncated)
Commits
fabd99b10.7.037c5e75Build: changelog update for 10.7.09489379chore: update dependency@eslint/eslintrcto ^3.3.6 (#21076)81a4774chore: updates for v9.39.5 release3e7bf15fix: applyignoreClassesWithImplementsto class expressions (#21069)9835414chore: enable$ExpectTypeannotations in all TypeScript files (#21071)cf2a9bffeat: add errorClassNames option to preserve-caught-error rule (#21032)c30d808docs: Update READMEf8b873afeat: max-nested-callbacks option for constructor callbacks (#21063)72adf6bchore: restrictmarkdownlint-cli2updates in renovate (#21067)Maintainer changes
This version was pushed to npm by eslintbot, a new releaser for eslint since your current version.
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.
Summary by CodeRabbit