The activesupport gem is a runtime dependency#9
Merged
vipulnsward merged 3 commits intobigbinary:masterfrom Jan 23, 2015
Merged
The activesupport gem is a runtime dependency#9vipulnsward merged 3 commits intobigbinary:masterfrom
vipulnsward merged 3 commits intobigbinary:masterfrom
Conversation
not just a development dependency, because of the use of String#blank? and Array.wrap in MailInterceptor::Interceptor.
Contributor
There was a problem hiding this comment.
Only following requires should suffice -
require 'active_support/core_ext/object/blank'
require 'active_support/core_ext/array'Can you update that?
Only require the minimum that we need for String#blank? and Array.wrap.
Put more important runtime dependencies at the top and sort alphabetically.
Contributor
|
Looks good to me. @vipulnsward please take a look. |
vipulnsward
added a commit
that referenced
this pull request
Jan 23, 2015
The activesupport gem is a runtime dependency
Contributor
|
Thanks @billhorsman ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
not just a development dependency, because of the use of String#blank?
and Array.wrap in MailInterceptor::Interceptor.