Merged
Conversation
Added required config changes for heroku logging.
The tagged logging configs are handled separately for each env.
ashiksp
force-pushed
the
290-config-updates
branch
from
f3df051 to
c96e1dc
Compare
ashiksp
force-pushed
the
290-config-updates
branch
from
c96e1dc to
656e65e
Compare
Contributor
Author
|
Neeraj: Please review and let me know changes if any. |
ashiksp
commented
Mar 14, 2020
| config.log_formatter = ::Logger::Formatter.new | ||
|
|
||
| # Do not dump schema after migrations. | ||
| config.active_record.dump_schema_after_migration = false |
Contributor
Author
There was a problem hiding this comment.
@neerajdotname The db:migrate rake task runs dump at the end which dumps the database structure to schema.rb file. It is useful in dev env, but not required in staging or production env, right ? By default, it's value is set to true.
It is not harm to run the task here even though it is not required. Any other specific reason to remove this flag ?
Correct me if I miss anything here.
References:
https://edgeguides.rubyonrails.org/configuring.html
https://groups.google.com/forum/#!topic/rubyonrails-core/h4cQXmKuB7M
rails/rails#13948
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #290