fix(toggle): id mismatch between toggle and its label#18
Closed
Arthurk12 wants to merge 14 commits intobigbluebutton:developfrom
Closed
fix(toggle): id mismatch between toggle and its label#18Arthurk12 wants to merge 14 commits intobigbluebutton:developfrom
Arthurk12 wants to merge 14 commits intobigbluebutton:developfrom
Conversation
Removed redundant permissions declaration from the publish job.
Removes registry-url to enable trusted publishing
Removes the trusted publisher authentication to publish package, since it didn't work. Updates the workflow to use NPM_TOKEN.
This workflow allows for manual tagging and releasing of the project, including generating automatic changelog and creating a GitHub release based on user input.
- Move @storybook/addon-a11y and @storybook/addon-actions to `devDependencies` - Update `webpack-dev-server` after running `npm audit` - Move @mui/icons-material to peerDependencies BREAKING CHANGE: @mui/icons-material has been moved from `dependencies` to `peerDependencies` to prevent version conflicts and reduced bundle size. Consumers must now install this package manually in their host application.
fix(BBBAccordion): prevent `scrollHeight` prop leakage to DOM & chore(deps)!: move dependencies to peer/dev and fix audit issues
Added repository information for the project.
…v2.0.0 The peerDependency transition was announced in v2.0.0 but the changes were omitted from the package.json due to a staging error. This commit rectifies the package manifest to align with the documented breaking change. Note: Version v2.0.0 remains functional if consumers manually install the missing dependency. However, upgrading to v2.0.1 is highly recommended to ensure correct NPM peer dependency warnings and project integrity.
fix: move '@mui/icons-material' to `peerDependencies` as intended in v2.0.0
When an id was passed to the toggle, the spread operator used to drill props into the underlying Material UI toggle was also overriding the internally calculated id, causing a mismatch with the label and preventing clicks on it from triggering the toggle action. The fix removes id from the restProps object, preventing it from overriding the correct internal id.
Member
Author
|
Closing in favor of #19 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
When an id was passed to the toggle, the spread operator used to drill props into the underlying Material UI toggle was also overriding the internally calculated id, causing a mismatch with the label and preventing clicks on it from triggering the toggle action.
The fix removes id from the restProps object, preventing it from overriding the correct internal id.
Closes
Closes #17