fix(toggle): id mismatch between toggle and its label#19
Merged
Arthurk12 merged 1 commit intobigbluebutton:developfrom Apr 8, 2026
Merged
fix(toggle): id mismatch between toggle and its label#19Arthurk12 merged 1 commit intobigbluebutton:developfrom
Arthurk12 merged 1 commit intobigbluebutton:developfrom
Conversation
When an id was passed to the toggle, the spread operator used to drill props into the underlying Material UI toggle was also overriding the internally calculated id, causing a mismatch with the label and preventing clicks on it from triggering the toggle action. The fix removes id from the restProps object, preventing it from overriding the correct internal id.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
When an id was passed to the toggle, the spread operator used to drill props into the underlying Material UI toggle was also overriding the internally calculated id, causing a mismatch with the label and preventing clicks on it from triggering the toggle action.
The fix removes id from the restProps object, preventing it from overriding the correct internal id.
Closes
Closes #17