Skip to content

feat: Sync Button and DynamicForm with VIBES#2110

Merged
jordanarldt merged 1 commit into
canaryfrom
ja/sync-button-and-form
Mar 19, 2025
Merged

feat: Sync Button and DynamicForm with VIBES#2110
jordanarldt merged 1 commit into
canaryfrom
ja/sync-button-and-form

Conversation

@jordanarldt

@jordanarldt jordanarldt commented Mar 18, 2025

Copy link
Copy Markdown
Contributor

What/Why?

Sync Button and DynamicForm component with VIBES
makeswift/vibes#606

Testing

Tested locally and build passes

@jordanarldt
jordanarldt requested a review from a team March 18, 2025 22:47
@changeset-bot

changeset-bot Bot commented Mar 18, 2025 •
edited
Loading

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 5070882

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel

vercel Bot commented Mar 18, 2025 •
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
catalyst-canary ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 19, 2025 5:18pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
catalyst ⬜️ Ignored (Inspect) Mar 19, 2025 5:18pm
catalyst-au ⬜️ Ignored (Inspect) Visit Preview Mar 19, 2025 5:18pm
catalyst-soul ⬜️ Ignored (Inspect) Visit Preview Mar 19, 2025 5:18pm
catalyst-uk ⬜️ Ignored (Inspect) Visit Preview Mar 19, 2025 5:18pm

@jordanarldt
jordanarldt force-pushed the ja/sync-button-and-form branch from 36191fd to 0e51b1f Compare March 18, 2025 22:48
chanceaclark
chanceaclark reviewed Mar 19, 2025
View reviewed changes
Comment thread core/vibes/soul/primitives/button/index.tsx Outdated
@jordanarldt
jordanarldt force-pushed the ja/sync-button-and-form branch from 0e51b1f to 5070882 Compare March 19, 2025 17:16
@jordanarldt
jordanarldt added this pull request to the merge queue Mar 19, 2025
Merged via the queue into canary with commit ffc81c4 Mar 19, 2025
@jordanarldt
jordanarldt deleted the ja/sync-button-and-form branch March 19, 2025 19:20
@github-actions

github-actions Bot commented Mar 19, 2025

Copy link
Copy Markdown
Contributor

⚡️🏠 Lighthouse report

Lighthouse ran against https://catalyst-canary-5oi45n3ze-bigcommerce-platform.vercel.app

🖥️ Desktop

We ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:

Category Score
🟢 Performance 99
🟢 Accessibility 92
🟠 Best practices 78
🟠 SEO 82

📱 Mobile

We ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:

Category Score
🟠 Performance 85
🟢 Accessibility 92
🟠 Best practices 78
🟠 SEO 85

migueloller added a commit that referenced this pull request Mar 31, 2025
@migueloller @agurtovoy
@chanceaclark @bc-svc-local @RomanKrasinskyi @hunterbecton @jorgemoya @deini @jordanarldt @bookernath
Merge canary to integrations/makeswift (#2167)
9d07a71 
* fix: switching locales redirects user to the home page (#1990)

* chore: add demo section to readme (#1996)

* Update translations (#1993)

* feat(other): LOCAL-1444 delivery translation

* chore(core): create translations patch

---------

Co-authored-by: bc-svc-local <bc-svc-local@users.noreply.github.com>

* feat: manage locales when creating storefronts from the CLI (#1986)

* feat: manage locales

* Add changeset

---------

Co-authored-by: Nathan Booker <nathan.booker@bigcommerce.com>

* feat: add default Tailwind typography styles (#2007)

* Update translations (#2004)

* feat(other): LOCAL-1444 delivery translation

* chore(core): create translations patch

---------

Co-authored-by: bc-svc-local <bc-svc-local@users.noreply.github.com>

* fix(core): handle registration errors in form (#2006)

* chore(release): publish create-catalyst CLI (#2015)

* chore: remove scoped version bump

* chore(release): publish create-catalyst CLI

* feat: add es-419 to list of allowed locale for selecting (#2017)

* feat(cli): scaffold package (#2010)

* fix(core): show coupon discounts as a separate summary item (#2084)

* fix(core): show coupon discounts as a separate summary item

* fix: typo in changeset

* feat(core): add shipping options to checkout (#1997)

* feat(core): add shipping options to checkout

* fix: capitalization of Edit

* fix: bump vibes

* fix: update vibes

* fix: remove else and early return

* refactor: simplify logic by using a Set for countries

* fix: hide forms visually

* fix: add no shipping options message

* fix: remove reduce and use Set, remove let variable

* fix: split mutations

* fix: disable complexity rule for Cart

* Update translations (#2104)

* feat(other): LOCAL-1444 delivery translation

* chore(core): create translations patch

---------

Co-authored-by: bc-svc-local <bc-svc-local@users.noreply.github.com>

* refactor: update signin behavior to use different providers (#2103)

* refactor: update signin behavior to use different providers

* chore: add additional folders to lint task

* feat: Sync Button and DynamicForm with VIBES (#2110)

* feat(core): add compare functionality to PLP (#2060)

* feat(core): migrate compare page to use soul

* feat: hide compare checkbox dynamically

* feat: pass in comparable products

* fix: add optimistic items

* feat: add optimistic to remove

* feat: add optimistic to checkbox

* fix: sort when added

* fix: sort groups and use link to compare

* fix: bump vibes components, fix button

* fix: remove unused primitves breadcrumbs component

* fix: sync vibes components

* fix: wrap transitions and call optimistic before setParam

* fix: validate with zod variables are correct

* fix: expose remove label

* fix: await setParam

* fix: translate remove label:

* fix: use parser and loader for compare

* feat: alert when max compare limit is set, disable checkboxes

* feat: Sync ProductCard and WishlistItemCard with VIBES (#2112)

* feat: Sync Breadcrumbs (#2117)

* feat: Add Wishlist VIBES components (#2118)

* chore(security): add documentation around CSRF checks (#2114)

* fix: set the trustHost value with an env var

* chore(core): documentation around CSRF checks within next-auth

* feat: Add wishlist translations, transformers, and core components (#2119)

* fix(core): revert to ids search param in compare page (#2125)

* feat(client): add errorPolicy option to GQL requests (#2124)

* feat: add anonymous session with cart tracking (#2111)

* refactor(core): abstract cart creation and addition logic (#2126)

* feat: Add wishlist modals, actions, and visibility switch (#2120)

* Bump next to address CVE (#2132)

* feat: Add wishlist modal defs, share button, and action dropdown menu (#2121)

* chore: update pnpm to 10.6.5 (#2135)

* Update translations (#2133)

* feat(other): LOCAL-1444 delivery translation

* chore(core): create translations patch

---------

Co-authored-by: bc-svc-local <bc-svc-local@users.noreply.github.com>
Co-authored-by: Jorge Moya <jorge.moya@bigcommerce.com>

* chore: update node to version 22 (#2136)

* chore: remove invalid changeset (#2139)

* feat: Add wishlist pages (#2122)

* fix(core): ignore errors in orders and render products without links (#2141)

* fix: add `Streamable.from` to avoid eager promises (#2143)

* feat: add Streamable.from

* fix: use Streamable.from instead of eager promises

* chore: update dependencies to latest minors (#2142)

* feat: group 1 update for Soul form components (#2130)

* feat(core): add store hash meta tag (#2147)

* fix: dedupe default image in PDP (#2162)

* feat: group 2 update for Soul form components (#2160)

* fix: remove unused components (#2163)

---------

Co-authored-by: Aleksey Gurtovoy <agurtovoy@acm.org>
Co-authored-by: Chancellor Clark <chancellor.clark@bigcommerce.com>
Co-authored-by: bc-svc-local <102379007+bc-svc-local@users.noreply.github.com>
Co-authored-by: bc-svc-local <bc-svc-local@users.noreply.github.com>
Co-authored-by: Roman Krasinskyi <49246595+RomanKrasinskyi@users.noreply.github.com>
Co-authored-by: Nathan Booker <nathan.booker@bigcommerce.com>
Co-authored-by: Hunter Garrett <hunter@hunterbecton.com>
Co-authored-by: Jorge Moya <jorge.moya@bigcommerce.com>
Co-authored-by: Daniel Almaguer <daniel.almaguer@bigcommerce.com>
Co-authored-by: Jordan Arldt <jordan.arldt@bigcommerce.com>
Co-authored-by: Nathan Booker <bookernath@users.noreply.github.com>
chanceaclark added a commit that referenced this pull request Apr 18, 2025
@migueloller @agurtovoy
@chanceaclark @bc-svc-local @RomanKrasinskyi @hunterbecton @jorgemoya @deini @jordanarldt @bookernath
Merge canary to integrations/makeswift (#2167)
7b8aae1 
* fix: switching locales redirects user to the home page (#1990)

* chore: add demo section to readme (#1996)

* Update translations (#1993)

* feat(other): LOCAL-1444 delivery translation

* chore(core): create translations patch

---------

Co-authored-by: bc-svc-local <bc-svc-local@users.noreply.github.com>

* feat: manage locales when creating storefronts from the CLI (#1986)

* feat: manage locales

* Add changeset

---------

Co-authored-by: Nathan Booker <nathan.booker@bigcommerce.com>

* feat: add default Tailwind typography styles (#2007)

* Update translations (#2004)

* feat(other): LOCAL-1444 delivery translation

* chore(core): create translations patch

---------

Co-authored-by: bc-svc-local <bc-svc-local@users.noreply.github.com>

* fix(core): handle registration errors in form (#2006)

* chore(release): publish create-catalyst CLI (#2015)

* chore: remove scoped version bump

* chore(release): publish create-catalyst CLI

* feat: add es-419 to list of allowed locale for selecting (#2017)

* feat(cli): scaffold package (#2010)

* fix(core): show coupon discounts as a separate summary item (#2084)

* fix(core): show coupon discounts as a separate summary item

* fix: typo in changeset

* feat(core): add shipping options to checkout (#1997)

* feat(core): add shipping options to checkout

* fix: capitalization of Edit

* fix: bump vibes

* fix: update vibes

* fix: remove else and early return

* refactor: simplify logic by using a Set for countries

* fix: hide forms visually

* fix: add no shipping options message

* fix: remove reduce and use Set, remove let variable

* fix: split mutations

* fix: disable complexity rule for Cart

* Update translations (#2104)

* feat(other): LOCAL-1444 delivery translation

* chore(core): create translations patch

---------

Co-authored-by: bc-svc-local <bc-svc-local@users.noreply.github.com>

* refactor: update signin behavior to use different providers (#2103)

* refactor: update signin behavior to use different providers

* chore: add additional folders to lint task

* feat: Sync Button and DynamicForm with VIBES (#2110)

* feat(core): add compare functionality to PLP (#2060)

* feat(core): migrate compare page to use soul

* feat: hide compare checkbox dynamically

* feat: pass in comparable products

* fix: add optimistic items

* feat: add optimistic to remove

* feat: add optimistic to checkbox

* fix: sort when added

* fix: sort groups and use link to compare

* fix: bump vibes components, fix button

* fix: remove unused primitves breadcrumbs component

* fix: sync vibes components

* fix: wrap transitions and call optimistic before setParam

* fix: validate with zod variables are correct

* fix: expose remove label

* fix: await setParam

* fix: translate remove label:

* fix: use parser and loader for compare

* feat: alert when max compare limit is set, disable checkboxes

* feat: Sync ProductCard and WishlistItemCard with VIBES (#2112)

* feat: Sync Breadcrumbs (#2117)

* feat: Add Wishlist VIBES components (#2118)

* chore(security): add documentation around CSRF checks (#2114)

* fix: set the trustHost value with an env var

* chore(core): documentation around CSRF checks within next-auth

* feat: Add wishlist translations, transformers, and core components (#2119)

* fix(core): revert to ids search param in compare page (#2125)

* feat(client): add errorPolicy option to GQL requests (#2124)

* feat: add anonymous session with cart tracking (#2111)

* refactor(core): abstract cart creation and addition logic (#2126)

* feat: Add wishlist modals, actions, and visibility switch (#2120)

* Bump next to address CVE (#2132)

* feat: Add wishlist modal defs, share button, and action dropdown menu (#2121)

* chore: update pnpm to 10.6.5 (#2135)

* Update translations (#2133)

* feat(other): LOCAL-1444 delivery translation

* chore(core): create translations patch

---------

Co-authored-by: bc-svc-local <bc-svc-local@users.noreply.github.com>
Co-authored-by: Jorge Moya <jorge.moya@bigcommerce.com>

* chore: update node to version 22 (#2136)

* chore: remove invalid changeset (#2139)

* feat: Add wishlist pages (#2122)

* fix(core): ignore errors in orders and render products without links (#2141)

* fix: add `Streamable.from` to avoid eager promises (#2143)

* feat: add Streamable.from

* fix: use Streamable.from instead of eager promises

* chore: update dependencies to latest minors (#2142)

* feat: group 1 update for Soul form components (#2130)

* feat(core): add store hash meta tag (#2147)

* fix: dedupe default image in PDP (#2162)

* feat: group 2 update for Soul form components (#2160)

* fix: remove unused components (#2163)

---------

Co-authored-by: Aleksey Gurtovoy <agurtovoy@acm.org>
Co-authored-by: Chancellor Clark <chancellor.clark@bigcommerce.com>
Co-authored-by: bc-svc-local <102379007+bc-svc-local@users.noreply.github.com>
Co-authored-by: bc-svc-local <bc-svc-local@users.noreply.github.com>
Co-authored-by: Roman Krasinskyi <49246595+RomanKrasinskyi@users.noreply.github.com>
Co-authored-by: Nathan Booker <nathan.booker@bigcommerce.com>
Co-authored-by: Hunter Garrett <hunter@hunterbecton.com>
Co-authored-by: Jorge Moya <jorge.moya@bigcommerce.com>
Co-authored-by: Daniel Almaguer <daniel.almaguer@bigcommerce.com>
Co-authored-by: Jordan Arldt <jordan.arldt@bigcommerce.com>
Co-authored-by: Nathan Booker <bookernath@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chanceaclark chanceaclark chanceaclark approved these changes
+1 more reviewer
@jamesqquick jamesqquick jamesqquick left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jordanarldt @jamesqquick @chanceaclark