fix: TRAC-296: Respect blog visibility setting in footer nav#3087
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: 0d1629d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Bundle Size ReportComparing against baseline from No bundle size changes detected. |
Footer "Navigate" section listed every page returned by content.pages without checking isVisibleInNavigation, so the Blog link always showed even when Blog visibility was turned off in Control Panel. Fetch isVisibleInNavigation on each page node and filter hidden pages out before rendering nav links. Fixes TRAC-296
jairo-bc
changed the title
jairo-bc
force-pushed
the
TRAC-296/fix/footer-blog-visibility
branch
from
624d375 to
ac4a87a
Compare
Contributor
Unlighthouse Performance Comparison — VercelComparing PR preview deployment Unlighthouse scores vs production Unlighthouse scores. Summary ScoreAggregate score across all categories as reported by Unlighthouse.
Category Scores
Core Web Vitals
|
rtalvarez
approved these changes
Jul 8, 2026
parthshahp
approved these changes
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What/Why?
Jira: TRAC-296
Blog visibility toggle in Control Panel (Storefront > Blogs) was not respected — the Blog link
always appeared in the storefront footer's "Navigate" section regardless of the setting.
Root cause:
FooterSectionsFragmentqueriescontent.pagesto build the footer's Navigatelinks, but never requested
isVisibleInNavigation, andFootermapped every returned pageinto a link unconditionally. Since
isVisibleInNavigationis exposed per-page on theWebPageinterface (including
BlogIndexPage), we now fetch it and filter hidden pages out beforerendering.
Testing
Before:
After:
Migration
None.