feat(client): add channelId as an optional param#994
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
5 Ignored Deployments
|
🦋 Changeset detectedLatest commit: 02dbbbf The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| if (!this.config.channelId || this.config.channelId === '1') { | ||
| private getEndpoint(channelId?: string) { | ||
| if (channelId && channelId !== '1') { | ||
| return `https://store-${this.config.storeHash}-${channelId}.${graphqlApiDomain}/graphql`; |
There was a problem hiding this comment.
We've backfilled all/most default channels with the channel-specific canonical URL, so we should be able to simplify this to https://store-${this.config.storeHash}-${channelId ?? this.config.channelId}.${graphqlApiDomain}/graphql and enforce channel ID to be set.
There was a problem hiding this comment.
Good info, wasn't aware of this.
57df2e5 to
02dbbbf
Compare
⚡️🏠 Lighthouse reportLighthouse ran against https://catalyst-latest-cmb9i8dwn-bigcommerce-platform.vercel.app 🖥️ DesktopWe ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:
📱 MobileWe ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:
|
2 participants
What/Why?
Testing
TBD