Add TE header for envoy requests#47
Merged
Merged
Conversation
splittingred
approved these changes
Mar 22, 2022
Contributor
There was a problem hiding this comment.
👍 Thanks for this, @joec4i - can you add a note to the CHANGELOG.md before merging?
splittingred
approved these changes
Mar 22, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the error
upstream connect error or disconnect/reset before headers. reset reason: remote resetwhen talking to some services via envoy.ping @splittingred
Note: It looks like CircleCI failed because of ssh key issue, but I don't have the permission to re-add CircleCI deploy key. @splittingred do you mind having a look at that too? Thanks!