Skip to content

interceptor improvements, drop php 7.3#50

Merged
splittingred merged 1 commit into
masterfrom
interceptor-improvements
Jul 29, 2022
Merged

interceptor improvements, drop php 7.3#50
splittingred merged 1 commit into
masterfrom
interceptor-improvements

Conversation

@splittingred

Copy link
Copy Markdown
Contributor

What?

  • Add getFullyQualifiedMethodName and getExpectedResponseMessageClass to base Client Interceptor class
  • Drop php 7.3 support (EOL)

@splittingred
splittingred requested review from a team, aleachjr and lord2800 July 29, 2022 18:47
@splittingred
splittingred force-pushed the interceptor-improvements branch from 3939b00 to f5a1252 Compare July 29, 2022 18:51
Comment thread src/Grphp/Client/Interceptors/Base.php
Comment thread src/Grphp/Client/Interceptors/Base.php
…s` to base Client Interceptor class, drop php 7.3
@splittingred
splittingred force-pushed the interceptor-improvements branch from f5a1252 to daefe96 Compare July 29, 2022 18:59
@splittingred
splittingred requested a review from aleachjr July 29, 2022 19:00
@aleachjr

Copy link
Copy Markdown
Contributor

Thanks for adding this in!

@splittingred
splittingred merged commit 338cfc5 into master Jul 29, 2022
@splittingred
splittingred deleted the interceptor-improvements branch July 29, 2022 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants