Merge dev-talesam into main - #37
Merged
Merged
Conversation
With no name typed yet there are no initials to show, and the placeholder was a question mark - which reads as something having gone wrong rather than as a field still to fill. The branding already ships the symbolic user icon the sidebar uses, so the preview shows that until a name arrives and the initials take over.
The cancel and close confirmations are plain QMessageBox instances built by Calamares with no object name of their own, so the branding stylesheet is the only handle on them - and CalamaresWindow applies that stylesheet to itself, which reaches them as its children. They came up cramped against their own text and with a tick and a cross on the buttons, the one piece of icon-theme artwork in a dialog otherwise drawn by the widget style, which is what made them look unlike the pages behind them. They get room now, and the buttons lose those icons and keep everything else the style gives them: setting a size or a padding on them made the style draw its default-button frame around the box while the button painted inside it, which showed as a second rectangle around the default button. The account preview shows the symbolic user glyph whatever the name is. It used to show initials, falling back to a question mark while the field was empty, and a question mark reads as something having gone wrong rather than as a field still to fill. Both profiles carrying the QML screens get it, so they do not drift apart.
Clicking Install used to raise a "Continue with Installation?" question that said what the page behind it already said, so it is switched off - the page is the confirmation - and the one sentence worth keeping, that the changes cannot be undone, sits on the page itself. That sentence is borrowed from the installer's own catalogue rather than translated again: it is the bold half of the dialog's question, so qsTranslate finds it in every language Calamares ships, and falls back to the English source the way the dialog did. The page it now has to carry that warning was a stack of full-width panels above a list that scrolled, and the warning would have scrolled away with it. The two panels sit side by side, the choices are cards with a coloured badge each - one hue per step, from icons recoloured here since the branding ships them all in the same blue - and the heading is just the title: the sentence under it repeated the panel below, and every line the heading takes is a line the choices lose. Together that is enough for four entries without a scroll bar. Panels are Frames, not Rectangles holding anchored children, so they take their size from their content instead of the other way round; and their heights are matched with a binding rather than Layout.fillHeight, which in a row inside a column also claims the space the list needs and left it with none. Every colour is the accent at a low alpha over the page, so one set of values reads on the light palette and on the dark one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request created by GitRepo.