Skip to content

Closes #161 #479

Merged
debajyotidatta merged 1 commit intobigscience-workshop:masterfrom
trishalaneeraj:mayosrs_tn
Apr 17, 2022
Merged

Closes #161 #479
debajyotidatta merged 1 commit intobigscience-workshop:masterfrom
trishalaneeraj:mayosrs_tn

Conversation

@trishalaneeraj
Copy link
Copy Markdown
Contributor

Closes #161

(This PS addresses PR comments from PR 460)

Checkbox

  • Confirm that this PR is linked to the dataset issue.
  • Create the dataloader script biodatasets/my_dataset/my_dataset.py (please use only lowercase and underscore for dataset naming).
  • Provide values for the _CITATION, _DATASETNAME, _DESCRIPTION, _HOMEPAGE, _LICENSE, _URLs, _SUPPORTED_TASKS, _SOURCE_VERSION, and _BIGBIO_VERSION variables.

NOTE: _LICENSE is "Unknown" in this case

  • Implement _info(), _split_generators() and _generate_examples() in dataloader script.
  • Make sure that the BUILDER_CONFIGS class attribute is a list with at least one BigBioConfig for the source schema and one for a bigbio schema.
  • Confirm dataloader script works with datasets.load_dataset function.
  • Confirm that your dataloader script passes the test suite run with python -m tests.test_bigbio biodatasets/my_dataset/my_dataset.py.
  • If my dataset is local, I have provided an output of the unit-tests in the PR (please copy paste). This is OPTIONAL for public datasets, as we can test these without access to the data files. (NOT APPLICABLE)

@trishalaneeraj
Copy link
Copy Markdown
Contributor Author

Hi @debajyotidatta - this PR is a follow-up from your comments on #460

Copy link
Copy Markdown
Collaborator

@debajyotidatta debajyotidatta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution.

@debajyotidatta debajyotidatta merged commit b359c23 into bigscience-workshop:master Apr 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create dataset loader for MayoSRS Reference Standard

2 participants