This repository was archived by the owner on Jul 14, 2020. It is now read-only.
Merged
Conversation
added 17 commits
September 4, 2018 19:58
Robdel12
approved these changes
Sep 14, 2018
Contributor
Robdel12
left a comment
There was a problem hiding this comment.
The changes to the opts are nice 👍 lines back up with my talks haha
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Adds unit tests and docs for most of the remaining run pieces.
Approach
The new CLI options are meant to remove the dot-notation. While being able to specify objects as arguments via the CLI is pretty cool, it has it's limitations. In most places we were using the dot-notation we needed to have special logic in place in order to properly merge options from the
optsfile. This special logic also included a hack involving specifying the type as an array which made the help output untrue and confusing.I probably should have split this up into multiple PRs, but it's been sitting around for a few days so I just wanted to get everything in (since it's mostly tests).
Todo