Skip to content

Fix: remove 'split' tab in DWG/PDF manager #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NicolasRichel merged 1 commit into from
Feb 3, 2022
Merged

Fix: remove 'split' tab in DWG/PDF manager #127

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/specific/models/models-manager/dwg-manager/DWGManager.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<template>
<ModelsManagerWrapper :project="project" :models="models" />
<ModelsManagerWrapper :project="project" :models="models" modelType="DWG" />
</template>

<script>
Expand Down
15 changes: 12 additions & 3 deletions ...components/specific/models/models-manager/models-manager-wrapper/ModelsManagerWrapper.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,11 @@ import ModelsActionBar from "../models-action-bar/ModelsActionBar.vue";
import ModelsDeleteModal from "../models-delete-modal/ModelsDeleteModal.vue";
import ModelsTable from "../models-table/ModelsTable.vue";

const tabsDef = [{ id: "upload" }, { id: "split" }, { id: "archive" }];
const tabsDef = {
DWG: [{ id: "upload" }, { id: "archive" }],
IFC: [{ id: "upload" }, { id: "split" }, { id: "archive" }],
PDF: [{ id: "upload" }, { id: "archive" }]
};

export default {
components: {
Expand All @@ -84,19 +88,24 @@ export default {
models: {
type: Array,
required: true
},
modelType: {
type: String,
default: "IFC",
validator: value => ["DWG", "IFC", "PDF"].includes(value)
}
},
setup(props) {
const { t } = useI18n();
const { updateModels, downloadModels: download } = useModels();

const tabs = computed(() =>
tabsDef.map(tab => ({
tabsDef[props.modelType].map(tab => ({
...tab,
label: t(`ModelsManager.tabs.${tab.id}`)
}))
);
const currentTab = ref(tabsDef[0].id);
const currentTab = ref(tabs.value[0].id);
const selectTab = tab => (currentTab.value = tab.id);

const modelLists = reactive({
Expand Down
2 changes: 1 addition & 1 deletion src/components/specific/models/models-manager/pdf-manager/PDFManager.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<template>
<ModelsManagerWrapper :project="project" :models="models" />
<ModelsManagerWrapper :project="project" :models="models" modelType="PDF" />
</template>

<script>
Expand Down